diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2015-11-15 14:52:08 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2015-11-15 15:25:51 +0100 |
| commit | 4a9af07a49295e014b059c1ab624c40345af5892 (patch) | |
| tree | b66df21c4cb3d453afabbec7f25cf0c05a61f139 | |
| parent | 6a69a175e7b5c5393528ed0f5753e41573fa0df2 (diff) | |
| download | ffmpeg-4a9af07a49295e014b059c1ab624c40345af5892.tar.gz | |
avcodec/smacker: Check that the data size is a multiple of a sample vector
Fixes out of array access
Fixes: ce19e41f0ef1e52a23edc488faecdb58/asan_heap-oob_2504e97_4202_ffa0df1baed14022b9bfd4f8ac23d0cb.smk
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/smacker.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index b2fc29b138..4014e8d04c 100644 --- a/libavcodec/smacker.c +++ b/libavcodec/smacker.c @@ -670,6 +670,10 @@ static int smka_decode_frame(AVCodecContext *avctx, void *data, /* get output buffer */ frame->nb_samples = unp_size / (avctx->channels * (bits + 1)); + if (unp_size % (avctx->channels * (bits + 1))) { + av_log(avctx, AV_LOG_ERROR, "unp_size %d is odd\n", unp_size); + return AVERROR(EINVAL); + } if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) return ret; samples = (int16_t *)frame->data[0]; |