diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2020-02-09 00:23:14 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2020-07-01 12:49:26 +0200 |
| commit | 3ea3a94a1e913ddf01efba1b1761063fa4971baa (patch) | |
| tree | 394544556c6ba77991d87246e88e8516580b55aa | |
| parent | 76ad5d0351fd7d01c0ba07a4b6a7c4ed679f4ae7 (diff) | |
| download | ffmpeg-3ea3a94a1e913ddf01efba1b1761063fa4971baa.tar.gz | |
avcodec/dstdec: Fix integer overflow in read_table()
Fixes: signed integer overflow: -16 * 134217879 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5639509530378240
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2d465a401dd790e2ca126ecb9cbda43f898a492f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/dstdec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c index c548174331..b70e0d27ec 100644 --- a/libavcodec/dstdec.c +++ b/libavcodec/dstdec.c @@ -155,7 +155,7 @@ static int read_table(GetBitContext *gb, Table *t, const int8_t code_pred_coeff[ for (j = method + 1; j < t->length[i]; j++) { int c, x = 0; for (k = 0; k < method + 1; k++) - x += code_pred_coeff[method][k] * t->coeff[i][j - k - 1]; + x += code_pred_coeff[method][k] * (unsigned)t->coeff[i][j - k - 1]; c = get_sr_golomb_dst(gb, lsb_size); if (x >= 0) c -= (x + 4) / 8; |