aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2020-06-18 11:52:47 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2020-07-02 17:18:55 +0200
commit3b8d5bcc3189c6c46279889f1176c0caba4466e4 (patch)
treeabccc4d229c2aac40d967367c4452350faeb0da5
parent2d96c945312d3f62e3f872bfb51a593afb40e09a (diff)
downloadffmpeg-3b8d5bcc3189c6c46279889f1176c0caba4466e4.tar.gz
avcodec/mv30: Fix integer overflows in idct2_1d()
Fixes: signed integer overflow: 6500736 * 473 cannot be represented in type 'int' Fixes: 23259/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5179394271477760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/mv30.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
index 76b9170eaf..c83ba7ffbd 100644
--- a/libavcodec/mv30.c
+++ b/libavcodec/mv30.c
@@ -200,10 +200,10 @@ static inline void idct2_1d(int *blk, int step)
{
const int t0 = blk[0 * step];
const int t1 = blk[1 * step];
- const int t2 = t1 * 473 >> 8;
+ const int t2 = (int)(t1 * 473U) >> 8;
const int t3 = t2 - t1;
- const int t4 = (t1 * 362 >> 8) - t3;
- const int t5 = ((t1 * 277 >> 8) - t2) + t4;
+ const int t4 = ((int)(t1 * 362U) >> 8) - t3;
+ const int t5 = (((int)(t1 * 277U) >> 8) - t2) + t4;
blk[0 * step] = t1 + t0;
blk[1 * step] = t0 + t3;