diff options
| author | Ronald S. Bultje <rsbultje@gmail.com> | 2015-04-22 14:53:01 -0400 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2015-05-15 10:04:50 +0200 |
| commit | 2ac7a0d999f1086d31b18102007eca347d73cc9c (patch) | |
| tree | e149a4f20459c5cbdbea637f47e078803ca6fefd | |
| parent | b35d67fa518c14f4970d630f5a068f0d73219215 (diff) | |
| download | ffmpeg-2ac7a0d999f1086d31b18102007eca347d73cc9c.tar.gz | |
vp9: remove one optimization branch in iadst16 which causes overflows.
See sample vp90-2-14-resize-fp-tiles-16-8-4-2-1.webm from the vp9 test
vector set which reproduces the issue. This probably costs a few cycles,
but I don't think there's an easy way to workaround that.
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit d02d04a18f300ebe97319ca6e91fc943cb14f58b)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/x86/vp9itxfm.asm | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/libavcodec/x86/vp9itxfm.asm b/libavcodec/x86/vp9itxfm.asm index bfe427fa70..a9d45a4b46 100644 --- a/libavcodec/x86/vp9itxfm.asm +++ b/libavcodec/x86/vp9itxfm.asm @@ -1699,7 +1699,9 @@ VP9_IDCT_IDCT_16x16_ADD_XMM avx SUMSUB_BA w, 5, 7, 4 PSIGNW m5, [pw_m1] ; m12=out15[w], m8=t3[w] -%if cpuflag(ssse3) + ; unfortunately, the code below overflows in some cases, e.g. + ; http://downloads.webmproject.org/test_data/libvpx/vp90-2-14-resize-fp-tiles-16-8-4-2-1.webm +%if 0 ; cpuflag(ssse3) SUMSUB_BA w, 7, 6, 4 pmulhrsw m7, [pw_m11585x2] ; m8=out7[w] pmulhrsw m6, [pw_11585x2] ; m1=out8[w] |