diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2019-06-16 15:53:27 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2019-06-26 21:25:56 +0200 |
| commit | 2921b45a388a81968d946996bb32e72d7bb5d5b7 (patch) | |
| tree | 57cc3bae4bc0f4d086c15efccc6168ce34b7a5a4 | |
| parent | d57f6606ebe166a428d939228d0d6490e3255ae1 (diff) | |
| download | ffmpeg-2921b45a388a81968d946996bb32e72d7bb5d5b7.tar.gz | |
avcodec/qdmc: Fix integer overflows in PRNG
Fixes: signed integer overflow: 214013 * 2531011 cannot be represented in type 'int'
Fixes: 15254/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDMC_fuzzer-5698137026461696
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/qdmc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/qdmc.c b/libavcodec/qdmc.c index 8f5b7b920d..8bea1552e1 100644 --- a/libavcodec/qdmc.c +++ b/libavcodec/qdmc.c @@ -577,9 +577,9 @@ static void add_noise(QDMCContext *s, int ch, int current_subframe) for (j = 2; j < s->subframe_size - 1; j++) { float rnd_re, rnd_im; - s->rndval = 214013 * s->rndval + 2531011; + s->rndval = 214013U * s->rndval + 2531011; rnd_im = ((s->rndval & 0x7FFF) - 16384.0f) * 0.000030517578f * s->noise2_buffer[j]; - s->rndval = 214013 * s->rndval + 2531011; + s->rndval = 214013U * s->rndval + 2531011; rnd_re = ((s->rndval & 0x7FFF) - 16384.0f) * 0.000030517578f * s->noise2_buffer[j]; im[j ] += rnd_im; re[j ] += rnd_re; |