diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2022-02-08 00:43:56 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2022-03-18 19:56:50 +0100 |
| commit | 28008bf95ed9b2ab5945ae6658358ad7c7f1df35 (patch) | |
| tree | 78a4dd153730c24e1a96d71f956fbe62f7ec0b28 | |
| parent | 8701af40bc5ef3dd2b4d3dc694062812806adc2a (diff) | |
| download | ffmpeg-28008bf95ed9b2ab5945ae6658358ad7c7f1df35.tar.gz | |
avcodec/sonic: Use unsigned for predictor_k to avoid undefined behavior
Fixes: signed integer overflow: -1094995529 * 24 cannot be represented in type 'int'
Fixes: 44436/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-4874459459223552
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/sonic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c index e4d44ea4d2..bd956aebd1 100644 --- a/libavcodec/sonic.c +++ b/libavcodec/sonic.c @@ -1009,7 +1009,7 @@ static int sonic_decode_frame(AVCodecContext *avctx, // dequantize for (i = 0; i < s->num_taps; i++) - s->predictor_k[i] *= s->tap_quant[i]; + s->predictor_k[i] *= (unsigned) s->tap_quant[i]; if (s->lossless) quant = 1; |