diff options
| author | Carl Eugen Hoyos <cehoyos@ag.or.at> | 2014-11-20 10:14:51 +0100 |
|---|---|---|
| committer | Carl Eugen Hoyos <cehoyos@ag.or.at> | 2014-11-20 10:14:51 +0100 |
| commit | 25ccf5df723c4e933f8cc25f36ba21264ef59a8c (patch) | |
| tree | 9cd9ca400a8a73406d14d6f040b72cd4a17125c1 | |
| parent | c661601f4583dbacf3dadbb48b3344f8188a49d6 (diff) | |
| download | ffmpeg-25ccf5df723c4e933f8cc25f36ba21264ef59a8c.tar.gz | |
lavf/mux: Always call write_trailer() from av_write_trailer() to avoid a leak.
Fixes ticket #4049.
| -rw-r--r-- | libavformat/mux.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/libavformat/mux.c b/libavformat/mux.c index a09e33cfdd..023832c336 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -926,7 +926,7 @@ int av_write_trailer(AVFormatContext *s) for (;; ) { AVPacket pkt; ret = interleave_packet(s, &pkt, NULL, 1); - if (ret < 0) //FIXME cleanup needed for ret<0 ? + if (ret < 0) goto fail; if (!ret) break; @@ -943,10 +943,14 @@ int av_write_trailer(AVFormatContext *s) goto fail; } +fail: if (s->oformat->write_trailer) + if (ret >= 0) { ret = s->oformat->write_trailer(s); + } else { + s->oformat->write_trailer(s); + } -fail: if (s->pb) avio_flush(s->pb); if (ret == 0) |