diff options
author | Paul B Mahol <onemda@gmail.com> | 2020-02-09 15:42:48 +0100 |
---|---|---|
committer | Paul B Mahol <onemda@gmail.com> | 2020-02-09 15:42:48 +0100 |
commit | 2174a315b46815ceb9ca9150650078b22ba0ad84 (patch) | |
tree | 64a2a7eecbf1db61ecc2175326717ac252f5e5cc | |
parent | 283e7557348a31e9a80e2f48bfc438278c2e6005 (diff) | |
download | ffmpeg-2174a315b46815ceb9ca9150650078b22ba0ad84.tar.gz |
avfilter/af_afffilt: fix crash on error
-rw-r--r-- | libavfilter/af_afftfilt.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/libavfilter/af_afftfilt.c b/libavfilter/af_afftfilt.c index 7506aebe9f..a14dd280e0 100644 --- a/libavfilter/af_afftfilt.c +++ b/libavfilter/af_afftfilt.c @@ -176,13 +176,13 @@ static int config_input(AVFilterLink *inlink) ret = av_expr_parse(&s->real[ch], arg ? arg : last_expr, var_names, NULL, NULL, func2_names, func2, 0, ctx); if (ret < 0) - break; + goto fail; if (arg) last_expr = arg; s->nb_exprs++; } - av_free(args); + av_freep(&args); args = av_strdup(s->img_str ? s->img_str : s->real_str); if (!args) @@ -196,12 +196,12 @@ static int config_input(AVFilterLink *inlink) ret = av_expr_parse(&s->imag[ch], arg ? arg : last_expr, var_names, NULL, NULL, func2_names, func2, 0, ctx); if (ret < 0) - break; + goto fail; if (arg) last_expr = arg; } - av_free(args); + av_freep(&args); s->fifo = av_audio_fifo_alloc(inlink->format, inlink->channels, s->window_size); if (!s->fifo) @@ -223,6 +223,9 @@ static int config_input(AVFilterLink *inlink) if (!s->buffer) return AVERROR(ENOMEM); +fail: + av_freep(&args); + return ret; } |