summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <[email protected]>2019-06-21 00:47:17 +0200
committerMichael Niedermayer <[email protected]>2020-07-01 12:11:55 +0200
commit213304972e459148c54c707943748a9062d60f5b (patch)
tree2076c4b8d763edd91b35f0c01a2f15ac99d52fde
parentb1334c774065939f8dc28d00c340f5d245e3968f (diff)
avcodec/alsdec: Fix integer overflow with buffer number
Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type 'int' Fixes: 15290/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5738074249625600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]> (cherry picked from commit 5f64f6058e0c23641a68ce7dfe47b1f55efd401c) Signed-off-by: Michael Niedermayer <[email protected]>
-rw-r--r--libavcodec/alsdec.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index ddcecdf61e..203d368b85 100644
--- a/libavcodec/alsdec.c
+++ b/libavcodec/alsdec.c
@@ -1999,6 +1999,8 @@ static av_cold int decode_init(AVCodecContext *avctx)
// allocate quantized parcor coefficient buffer
num_buffers = sconf->mc_coding ? avctx->channels : 1;
+ if (num_buffers * (uint64_t)num_buffers > INT_MAX) // protect chan_data_buffer allocation
+ return AVERROR_INVALIDDATA;
ctx->quant_cof = av_malloc_array(num_buffers, sizeof(*ctx->quant_cof));
ctx->lpc_cof = av_malloc_array(num_buffers, sizeof(*ctx->lpc_cof));