aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-02-09 19:40:34 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2020-02-11 00:03:44 +0100
commit212077eda46c4c3eb644774d2b1ccbeb3e322fff (patch)
treefed31d82ce680a68a250c67fe167ab1baa15e986
parent6a67d518d60b61ae2bd98c3948894a7be9955e8c (diff)
downloadffmpeg-212077eda46c4c3eb644774d2b1ccbeb3e322fff.tar.gz
avfilter/vf_dedot: Fix leak of AVFrame if making it writable fails
Even in this scenario, the frame still contains references to data that won't be freed if the frame isn't unreferenced. And the AVFrame itself will leak, too. Fixes Coverity issue #1441422. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavfilter/vf_dedot.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/libavfilter/vf_dedot.c b/libavfilter/vf_dedot.c
index 1fb7bfe866..993ac8f74f 100644
--- a/libavfilter/vf_dedot.c
+++ b/libavfilter/vf_dedot.c
@@ -313,7 +313,8 @@ static int activate(AVFilterContext *ctx)
FFMIN(s->planeheight[2],
ff_filter_get_nb_threads(ctx)));
}
- }
+ } else
+ av_frame_free(&out);
} else if (!out) {
ret = AVERROR(ENOMEM);
}