summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <[email protected]>2015-11-06 22:24:23 +0100
committerMichael Niedermayer <[email protected]>2015-11-07 01:10:58 +0100
commit11b4822ddb3eaa6627f2e83fa2e934d39d7ce2b1 (patch)
treec501a9906b13714031eb245a6324ba69cb0d8b26
parent2de2959305c57683e8ce9832395f465a2bc13dcf (diff)
avcodec/microdvddec: Check for string end in 'P' case
Fixes out of array read Fixes: a9502b60f4cecc19475382aee255f73c/asan_heap-oob_1e87fba_2548_a8ad47f6dde36644fe9cdc444d4632d0.sub Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]> (cherry picked from commit c719cd6cf79ec21d974b81ba874580f4b8e9eb90) Signed-off-by: Michael Niedermayer <[email protected]>
-rw-r--r--libavcodec/microdvddec.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libavcodec/microdvddec.c b/libavcodec/microdvddec.c
index 96034a042a..9035892205 100644
--- a/libavcodec/microdvddec.c
+++ b/libavcodec/microdvddec.c
@@ -164,6 +164,8 @@ static char *microdvd_load_tags(struct microdvd_tag *tags, char *s)
/* Position */
case 'P':
+ if (!*s)
+ break;
tag.persistent = MICRODVD_PERSISTENT_ON;
tag.data1 = (*s++ == '1');
if (*s != '}')