diff options
author | Zhao Zhili <quinkblack@foxmail.com> | 2022-06-27 17:57:27 +0800 |
---|---|---|
committer | Zhao Zhili <zhilizhao@tencent.com> | 2022-07-04 11:30:08 +0800 |
commit | 066368e8373d18b496203fa91d98bf11a9b7f59f (patch) | |
tree | 494494f3ffbdf30ffbe6e95e64e4552d6401baee | |
parent | 9fec43a92d7304fc594dcf73c6dd3144b855617d (diff) | |
download | ffmpeg-066368e8373d18b496203fa91d98bf11a9b7f59f.tar.gz |
avcodec/libdavs2: workaround memory leak
davs2_decoder_close doesn't free those on the fly frames which
don't get output yet. It's a design bug, but easy to workaround.
Before the patch:
Direct leak of 1198606 byte(s) in 2 object(s) allocated from:
#0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0)
#1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240
#2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815
Indirect leak of 3595818 byte(s) in 6 object(s) allocated from:
#0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0)
#1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240
#2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815
Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
-rw-r--r-- | libavcodec/libdavs2.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c index d7625718a2..c2040775ae 100644 --- a/libavcodec/libdavs2.c +++ b/libavcodec/libdavs2.c @@ -177,6 +177,7 @@ static av_cold int davs2_end(AVCodecContext *avctx) /* close the decoder */ if (cad->decoder) { + davs2_flush(avctx); davs2_decoder_close(cad->decoder); cad->decoder = NULL; } |