aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-03-28 00:26:06 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-03 23:16:24 +0200
commit01d8c887f63bcb1f870034ed441504b3daffc645 (patch)
tree277ae238050031ec44fa2d090d12a96e271c1272
parentb085b400becb93ccc68d786ab738b1fc50408b89 (diff)
downloadffmpeg-01d8c887f63bcb1f870034ed441504b3daffc645.tar.gz
avcodec/takdsp: Fix integer overflow in decorrelate_sf()
Fixes: signed integer overflow: -101 * 71041254 cannot be represented in type 'int' Fixes: 45938/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-4687974320701440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/takdsp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/takdsp.c b/libavcodec/takdsp.c
index 9cb8052596..a8f9dba342 100644
--- a/libavcodec/takdsp.c
+++ b/libavcodec/takdsp.c
@@ -65,7 +65,7 @@ static void decorrelate_sf(int32_t *p1, int32_t *p2, int length, int dshift, int
for (i = 0; i < length; i++) {
int32_t a = p1[i];
int32_t b = p2[i];
- b = (unsigned)(dfactor * (b >> dshift) + 128 >> 8) << dshift;
+ b = (unsigned)((int)(dfactor * (unsigned)(b >> dshift) + 128) >> 8) << dshift;
p1[i] = b - a;
}
}