| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
| |
- Changelog entry
Type: feature
Component: master
Introduce TCompactTableSchema, that holds wire protobuf schema representation and lighter than TTableSchema
commit_hash:21801854b37fc25c5004ee01e5b79a3b3b6ea983
|
| |
|
|
| |
commit_hash:dc1bba1db2b4a5bae15299e926e816920168018f
|
| |
|
|
| |
commit_hash:af266bdf36204a4190b491ea5c45455457030edf
|
| |
|
|
|
|
|
| |
Идея такая: хочу подкладывать атрибуты в ошибки, не протаскивая их через стек (как в orm/server/objects) и не прогоняя все ошибки через специальные методы (как в orm/library/attributes). Для этого завожу fiber-local структурку с ленивым выведением строчек. Поскольку TError и TFls живут в разных мирах, пришлось сделать отдельный трамплин для совсем генеричной доработки ошибок в момент создания.
Игнат посоветовал глянуть на Codicil. Там очень похоже, но нет key/value, поэтому похитил только название. Вообще, можно унифицировать, если есть запрос.
commit_hash:203ec7abe5e8c8484e66d55f16192485db776806
|
| |
|
|
|
| |
[nodiff:runtime]
commit_hash:1ba799aed1703ab7c6304b6da7090b3337f768dd
|
| |
|
|
|
|
|
|
|
|
|
| |
Here we can avoid dynamic cast and exception hazard.
Signed-off-by: Konstantin Khlebnikov <[email protected]>
---
Pull Request resolved: https://github.com/ytsaurus/ytsaurus/pull/1070
commit_hash:e0709e1fe0f2109792b20b850e0e11a6e96f846a
|
| |
|
|
| |
commit_hash:55e574599005f5286f646ebba93d5550325708bc
|
| |
|
|
|
|
|
|
|
| |
* Changelog entry
Type: fix
Component: misc-server
Fix UB in chunked memory pool
commit_hash:d2d5a9707e30abe1814d1ac0c33fc0f2aba134e2
|
| |
|
|
|
|
|
|
|
| |
Приедет в ytsaurus: <HIDDEN_URL>
Приедет в `/contrib/ydb/` <HIDDEN_URL>
Проверка, что в github ydb ничего не сломается: <https://github.com/ydb-platform/ydb/pull/13286>
commit_hash:73ab1b4a3245322afc9fc6e9d71424ad07106477
|
| |
|
|
| |
commit_hash:51660c0e427c358c8285a5889c7dd585a97e5140
|
| |
|
|
| |
commit_hash:3f7d1518427ed170b9ac8f70724290b71801cae4
|
| |
|
|
| |
commit_hash:e5c092a9d0375881554f1d3bc905c662070956bf
|
| |
|
|
| |
commit_hash:a4ecfb1e06e82ba192646d3ab5417cb3f0c6991f
|
| |
|
|
|
|
|
|
|
| |
1. Prevent concurrent crashes to interleave in stderr
2. Cleaner and more compact formatting of registers dump
3. Omit `OLDMASK` (nobody seems to know what is it for)
4. Don't print the top backtrace frame twice
5. Code cosmetics
commit_hash:f7a4c960b3400d6dfb0f8f60317aa524611d2fd0
|
| |
|
|
|
| |
[nodiff:caesar]
commit_hash:62fa96ca05b1a4018e2e51e6b589483cd3a44fc4
|
| |
|
|
| |
commit_hash:deadebefdfd81b6c737b9464435356b8f652e296
|
| |
|
|
| |
commit_hash:afeeeea3c2cbdec0ddeed0fea5f88df9d8575f8b
|
| |
|
|
| |
commit_hash:5dda6f5ef324f03c99af3dae32ebf4a059f02bd3
|
| |
|
|
| |
commit_hash:747602d8e470d51bcf6f38dfddafa12047d210df
|
| |
|
|
| |
commit_hash:fc31d2770ebeffeb513c4535bd146c731b7f78fb
|
| |
|
|
| |
commit_hash:f51f172878d227b49cb480296f61a6575e5d6e67
|
| |
|
|
| |
commit_hash:19b37bd3d7e3b4d80e4844676c881bbef1fec76b
|
| |
|
|
|
|
|
| |
std::string everywhere
done
commit_hash:8a83afa39917ba66a5161388a7cd74a4488d9908
|
| |
|
|
| |
commit_hash:c87fb9e7c5cb8a896dd4b758ad73c5c540339df7
|
| |
|
|
| |
commit_hash:19481c9fbb008aab4f4d676f1a3a242f6e90e90e
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
becoming CPO, move TErrorCode and TError to library/cpp/yt/error
\[nodiff:caesar\]
List of changes:
1) Make `ConvertTo` a normal function again (basically, a revert of previous change). It turned out to be very inconvenient entry point
2) Introduce concept for "Primitive types" which are handled without yt/core module. Please note that inclusion of core **does not** affect work with primitive types (otherwise we would be facing and ODR violation). These are numerics, duration, instant, string-like objects and guid
3) Introduce `FromErrorAttributeValue` which is a substitute to `ConvertTo` with special behavior (see below)
4) Scheme for (de-)serialization has changed:
1) Primitive types are handled via `ConvertToTextYsonString` and `ConvertFromTextYsonString`
2) Other types are not supported without yt/core. Otherwise `ConvertToYsonString(value, EYsonFormat::Text)` used for serialization and `ConvertTo<T>(value)` for deserialization.
5) New format of attribute value storage allows to not care about concrete type of the attribute (text yson strings can be detected since they start with `\"` and deserialized so are text yson bools, everything else is already human readable). This drops dependency on `TTokenizer`
6) Some small parts (e.g. enums or constants or aliases) of yt/core/misc files were moved to library/cpp/yt/\* locations and re-included to drop dependencies of stripped\_error on them
7) `TErrorAttributes` is now a simple hash map instead of a handle to `IAttributeDictionary`
8) `ExtractFromAttributes` weak symbol is finally moved to library/cpp/yt/error due to point 9 allowing to fully drop dependency on `IAttributeDictionary`. Combined with point 7 this drops dep on yt/core/ytree altogether
9) Moved `TErrorCode` to library/cpp/yt/error. There is a logger there which forces dep on library/cpp/yt/logging. It is not required really, and can be later removed
10) Moved `TError` with format and macroes to library/cpp/yt/error. It still (and probably forever will) depend on yson.
What can be done next: Switch TYsonString to TString and move ConvertTo/FromTextYsonString to library/cpp/yt/error. This would remove dep on library/cpp/yt/yson\_string
commit_hash:6f11dc478ab782a1f98a5aedcd45a4800d3f4e7b
|
| |
|
|
| |
commit_hash:a31e79330e3ec72361743d932a47fc67f92fb7a0
|
| |
|
|
| |
commit_hash:41c16027e2f796197b98307419a63da9fa3f1a88
|
| |
|
|
| |
commit_hash:534ea2df7961feea6932d1e243df20d825c7fe69
|
| |
|
|
|
|
| |
library/cpp/yt/yson_string to be later used for error attribute serialization
commit_hash:f7632c9622c71e023148c9454a9889e9cac75ecd
|
| |
|
|
| |
commit_hash:690d178c5c95ad7106aee6c26a031e6eeec1f093
|
| |
|
|
| |
commit_hash:57515baf5d33fd78c2555cb2b3351498b9189c72
|
| |
|
|
| |
commit_hash:79b0a0b437e41879c3a7d4c079ab571bbaafd45f
|
| |
|
|
| |
commit_hash:7d3055f901a21e63f7860f443252a86e9895fd08
|
| |
|
|
| |
commit_hash:06fd6ffa9ec768168c34547fcdfb15e2f9ad75f8
|
| |
|
|
| |
commit_hash:7b57398460fb850349f35c543b8cef63f6490b6b
|
| |
|
|
| |
commit_hash:50f729d3716d8b1f5b852cfc008e228172fb79c4
|
| |
|
|
| |
commit_hash:87c6f9898873ec96e4aa9dc4c7df86e67a11e313
|
| |
|
|
| |
commit_hash:97159680fa733af4212c094e917bc78a47eb0c15
|
| |
|
|
| |
commit_hash:cbf5ab65e5ba1b2d286f974a6b6b463ed152b381
|
| |
|
|
| |
commit_hash:320ab736dea5dae74e2ec8c344fb915be4c4df99
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TErrorAttribute from yt/core
Plan:
1) Remove `IAttributedDictionary` type from the public API. \+
2) Remove `Set` method from public API in favor of `operator<<=`. \+
3) Adopt `ConvertTo<T>` (or other name) CPO with proper extension into `NYT::NYson::ConvertTo` from `yt/core`.
4) Use CPO from (3) to eliminate direct dependency on `yt/core` of `Get/Find` methods from attributes API.
5) Adopt `ConvertToYsonString` (or other name) CPO with proper extension into `yt/core` customisations.
6) Use CPO from (5) to eliminate direct dependency on `yt/core` of `TErrorAttribute` ctor.
7) Swap attributes implementation to the one which doesn’t use `IAttributeDictionary`.
8) At this point `stripped_error*` can be moved to library/cpp/yt and so can recursively dependant on THROW macro methods `Get/Find/…`.
9) Adjust CPO’s to work with `std::string` instead of `TYsonString` assuming text format to be used (maybe `TString` for now).
10) Remove dep of `library/cpp/yt/error` on `yson` entirely.
This pr addresses 5-6 steps of plan. Below is a brief explanation of design decisions. We also expressed everything related to key-value code in terms of aliases of `TErrorAttribute` so that later we could make a relatively simple switch to `std::string`. We expect to do steps 7-8 in the next pull request as everything should be ready
commit_hash:de9feca2bd24d823b33d904ef0fa5f4856f9b020
|
| |
|
|
| |
commit_hash:60e005cdf76d5bff2a370a6b8f35ef4f6792f414
|
| |
|
|
| |
commit_hash:804530d1ee861ff42d7d8cad25d9f569b4feaacf
|
| |
|
|
| |
commit_hash:5ce8019253cdb971d1af36350e3efa3a4ec8545c
|
| |
|
|
|
| |
[nodiff:caesar]
commit_hash:93eef00a7132e68e727aa1f4028616db6522d03c
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Y_ASSUME and Y_UNREACHABLE macros are platform-independent ways to
give a hint for a compiler about some value or state. Compilier may
use that hint for optimization. On the other hand if the hint is
wrong it may lead to undefined behavior.
YT_ASSUME and YT_UNREACHABLE are wrappers around Y_ASSUME and
Y_UNREACHABLE that actually check that the hint is correct in
debug build. That introduces some code safety and at the same time
allows certain optimization in optimized build.
commit_hash:2d0969361910a10a870bae226d838d494e656edb
|
| |
|
|
| |
commit_hash:2edff041e77ead18a6bb7efeb13c8163d85c0750
|
| |
|
|
| |
commit_hash:17dbd6d7e5fc440afa2d816e245a73e25135bfb5
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plan:
1) Remove `IAttributedDictionary` type from the public API. \+
2) Remove `Set` method from public API in favor of `operator<<=`. \+
3) Adopt `ConvertTo<T>` (or other name) CPO with proper extension into `NYT::NYson::ConvertTo` from `yt/core`.
4) Use CPO from (3) to eliminate direct dependency on `yt/core` of `Get/Find` methods from attributes API.
5) Adopt `ConvertToYsonString` (or other name) CPO with proper extension into `yt/core` customisations.
6) Use CPO from (5) to eliminate direct dependency on `yt/core` of `TErrorAttribute` ctor.
7) Swap attributes implementation to the one which doesn’t use `IAttributeDictionary`.
8) At this point `stripped_error*` can be moved to library/cpp/yt and so can recursively dependant on THROW macro methods `Get/Find/…`.
9) Adjust CPO’s to work with `std::string` instead of `TYsonString` assuming text format to be used (maybe `TString` for now).
10) Remove dep of `library/cpp/yt/error` on `yson` entirely.
This pr addresses 3-4 steps of plan. Below is a brief explanation of design decisions.
We want to have a concept which detects if there is a `ConvertTo` method and if true, try calling it. Templates can only perform unqualified name lookup and if we allow non-ADL overloads to be found, we would have dependency on inclusion order (if `ConvertTo` is included prior to our code, everything works fine, but if the order is reverse, templated dispatch would fail, but direct call would work just fine). That is why we adopt niebloids which first disable ADL lookup of the name `ConvertTo` by directing it to niebloid implemented via `TagInvoke` mechanism. TagInvoke design <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1895r0.pdf> . TL;DR: we want to have behavior which is consistent with inclusion order.
Key difference now is that `ConvertTo` works consistently in both manual calls and template function body calls and is no longer visible for ADL part of the unqualified name lookup
commit_hash:32af641bd0af559bfe670c2ceb36721fb4afc2dd
|