diff options
author | Aleksandr Dmitriev <alexd.65536@gmail.com> | 2022-05-20 14:25:52 +0300 |
---|---|---|
committer | Aleksandr Dmitriev <alexd.65536@gmail.com> | 2022-05-20 14:25:52 +0300 |
commit | 5b4ed9e881a9fc8cb3aa1d0e1daed0c1d5f06294 (patch) | |
tree | d0b0f8252e775f8288984ea4d9729d431afe99b7 /library | |
parent | 4359bcaf9ff4a17a91f93781db67f9cdb772be65 (diff) | |
download | ydb-5b4ed9e881a9fc8cb3aa1d0e1daed0c1d5f06294.tar.gz |
remove old histograms KIKIMR-12059
ref:c18e95202765a99edf984c6cf07a69abe4602607
Diffstat (limited to 'library')
6 files changed, 5 insertions, 15 deletions
diff --git a/library/cpp/actors/interconnect/interconnect_channel.h b/library/cpp/actors/interconnect/interconnect_channel.h index e4a0ae3cdab..cf68cd27fd3 100644 --- a/library/cpp/actors/interconnect/interconnect_channel.h +++ b/library/cpp/actors/interconnect/interconnect_channel.h @@ -9,7 +9,6 @@ #include <util/generic/map.h> #include <util/stream/walk.h> #include <library/cpp/actors/wilson/wilson_event.h> -#include <library/cpp/actors/helpers/mon_histogram_helper.h> #include "interconnect_common.h" #include "interconnect_counters.h" diff --git a/library/cpp/actors/interconnect/interconnect_counters.cpp b/library/cpp/actors/interconnect/interconnect_counters.cpp index 224160d4b4f..5d0b31737c3 100644 --- a/library/cpp/actors/interconnect/interconnect_counters.cpp +++ b/library/cpp/actors/interconnect/interconnect_counters.cpp @@ -205,8 +205,7 @@ namespace { *TotalBytesRead += value; } - void UpdateLegacyPingTimeHist(ui64 value) override { - LegacyPingTimeHist.Add(value); + void UpdatePingTimeHistogram(ui64 value) override { PingTimeHistogram->Collect(value); } @@ -278,9 +277,6 @@ namespace { InflyLimitReach = AdaptiveCounters->GetCounter("InflyLimitReach", true); InflightDataAmount = AdaptiveCounters->GetCounter("Inflight_Data"); - LegacyPingTimeHist = {}; - LegacyPingTimeHist.Init(AdaptiveCounters.Get(), "PingTimeHist", "mks", 125, 18); - PingTimeHistogram = AdaptiveCounters->GetHistogram( "PingTimeUs", NMonitoring::ExponentialHistogram(18, 2, 125)); } @@ -329,7 +325,6 @@ namespace { NMonitoring::TDynamicCounters::TCounterPtr SpuriousReadWakeups; NMonitoring::TDynamicCounters::TCounterPtr UsefulWriteWakeups; NMonitoring::TDynamicCounters::TCounterPtr SpuriousWriteWakeups; - NMon::THistogramCounterHelper LegacyPingTimeHist; NMonitoring::THistogramPtr PingTimeHistogram; std::unordered_map<ui16, TOutputChannel> OutputChannels; @@ -520,7 +515,7 @@ namespace { TotalBytesRead_->Add(value); } - void UpdateLegacyPingTimeHist(ui64 value) override { + void UpdatePingTimeHistogram(ui64 value) override { PingTimeHistogram_->Record(value); } diff --git a/library/cpp/actors/interconnect/interconnect_counters.h b/library/cpp/actors/interconnect/interconnect_counters.h index e30f03a0bcc..b5a63b45513 100644 --- a/library/cpp/actors/interconnect/interconnect_counters.h +++ b/library/cpp/actors/interconnect/interconnect_counters.h @@ -1,7 +1,5 @@ #pragma once -#include <library/cpp/actors/helpers/mon_histogram_helper.h> - #include <util/system/valgrind.h> #include "types.h" @@ -42,7 +40,7 @@ public: virtual void IncInputChannelsIncomingEvents(ui16 channel) = 0; virtual void IncRecvSyscalls() = 0; virtual void AddTotalBytesRead(ui64 value) = 0; - virtual void UpdateLegacyPingTimeHist(ui64 value) = 0; + virtual void UpdatePingTimeHistogram(ui64 value) = 0; virtual void UpdateOutputChannelTraffic(ui16 channel, ui64 value) = 0; virtual void UpdateOutputChannelEvents(ui16 channel) = 0; TString GetHumanFriendlyPeerHostName() const { diff --git a/library/cpp/actors/interconnect/interconnect_impl.h b/library/cpp/actors/interconnect/interconnect_impl.h index ee29e4d3971..db598546cc9 100644 --- a/library/cpp/actors/interconnect/interconnect_impl.h +++ b/library/cpp/actors/interconnect/interconnect_impl.h @@ -3,7 +3,6 @@ #include "interconnect.h" #include <library/cpp/actors/protos/interconnect.pb.h> #include <library/cpp/actors/core/event_pb.h> -#include <library/cpp/actors/helpers/mon_histogram_helper.h> #include <library/cpp/monlib/dynamic_counters/counters.h> namespace NActors { diff --git a/library/cpp/actors/interconnect/interconnect_tcp_input_session.cpp b/library/cpp/actors/interconnect/interconnect_tcp_input_session.cpp index c7fca64c600..65bb956e584 100644 --- a/library/cpp/actors/interconnect/interconnect_tcp_input_session.cpp +++ b/library/cpp/actors/interconnect/interconnect_tcp_input_session.cpp @@ -197,7 +197,7 @@ namespace NActors { ui64 sendTime = AtomicGet(Context->ControlPacketSendTimer); TDuration duration = CyclesToDuration(GetCycleCountFast() - sendTime); const auto durationUs = duration.MicroSeconds(); - Metrics->UpdateLegacyPingTimeHist(durationUs); + Metrics->UpdatePingTimeHistogram(durationUs); PingQ.push_back(duration); if (PingQ.size() > 16) { PingQ.pop_front(); @@ -456,7 +456,7 @@ namespace NActors { const auto pingUs = ping.MicroSeconds(); Context->PingRTT_us = pingUs; NewPingProtocol = true; - Metrics->UpdateLegacyPingTimeHist(pingUs); + Metrics->UpdatePingTimeHistogram(pingUs); } void TInputSessionTCP::HandleClock(TInstant clock) { diff --git a/library/cpp/actors/interconnect/interconnect_tcp_session.h b/library/cpp/actors/interconnect/interconnect_tcp_session.h index c7f3113b55a..5d4a381e1f5 100644 --- a/library/cpp/actors/interconnect/interconnect_tcp_session.h +++ b/library/cpp/actors/interconnect/interconnect_tcp_session.h @@ -4,7 +4,6 @@ #include <library/cpp/actors/core/event_pb.h> #include <library/cpp/actors/core/events.h> #include <library/cpp/actors/core/log.h> -#include <library/cpp/actors/helpers/mon_histogram_helper.h> #include <library/cpp/actors/protos/services_common.pb.h> #include <library/cpp/actors/util/datetime.h> #include <library/cpp/actors/util/rope.h> |