YT-22885: DEFINE_ENUM_UNKNOWN_VALUE, string-related conversions

commit_hash:14c7e42422af750383f04855b4a7ea6b267b92d2

1 files changed, 15 insertions, 20 deletions

diff --git a/library/cpp/yt/string/enum.cpp b/library/cpp/yt/string/enum.cpp
index e61b813fd21..935c3e6e3ef 100644
--- a/library/cpp/yt/string/enum.cpp
+++ b/library/cpp/yt/string/enum.cpp
@@ -6,13 +6,22 @@ namespace NYT {
 
 ////////////////////////////////////////////////////////////////////////////////
 
-template <bool failOnError>
+namespace NDetail {
+
+void ThrowMalformedEnumValueException(TStringBuf typeName, TStringBuf value)
+{
+    throw TSimpleException(Format("Error parsing %v value %Qv",
+        typeName,
+        value));
+}
+
+template <bool ThrowOnError>
 std::optional<TString> DecodeEnumValueImpl(TStringBuf value)
 {
     auto camelValue = UnderscoreCaseToCamelCase(value);
     auto underscoreValue = CamelCaseToUnderscoreCase(camelValue);
     if (value != underscoreValue) {
-        if constexpr (failOnError) {
+        if constexpr (ThrowOnError) {
             throw TSimpleException(Format("Enum value %Qv is not in a proper underscore case; did you mean %Qv?",
                 value,
                 underscoreValue));
@@ -23,14 +32,16 @@ std::optional<TString> DecodeEnumValueImpl(TStringBuf value)
     return camelValue;
 }
 
+} // namespace NDetail
+
 std::optional<TString> TryDecodeEnumValue(TStringBuf value)
 {
-    return DecodeEnumValueImpl<false>(value);
+    return NDetail::DecodeEnumValueImpl<false>(value);
 }
 
 TString DecodeEnumValue(TStringBuf value)
 {
-    auto decodedValue = DecodeEnumValueImpl<true>(value);
+    auto decodedValue = NDetail::DecodeEnumValueImpl<true>(value);
     YT_VERIFY(decodedValue);
     return *decodedValue;
 }
@@ -40,22 +51,6 @@ TString EncodeEnumValue(TStringBuf value)
     return CamelCaseToUnderscoreCase(value);
 }
 
-namespace NDetail {
-
-void ThrowMalformedEnumValueException(TStringBuf typeName, TStringBuf value)
-{
-    throw TSimpleException(Format("Error parsing %v value %Qv",
-        typeName,
-        value));
-}
-
-void FormatUnknownEnumValue(TStringBuilderBase* builder, TStringBuf name, i64 value)
-{
-    builder->AppendFormat("%v(%v)", name, value);
-}
-
-} // namespace NDetail
-
 ////////////////////////////////////////////////////////////////////////////////
 
 } // namespace NYT