aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIlnaz Nizametdinov <i.nizametdinov@gmail.com>2022-06-30 15:58:25 +0300
committerIlnaz Nizametdinov <i.nizametdinov@gmail.com>2022-06-30 15:58:25 +0300
commitfb18373884e263729ed2c491b938573b1ff2bc71 (patch)
treedde84f185c3318027a81e9287617531f2b57a3ba
parente4884481e0ccc5666bc1459861b14a554db5ff0e (diff)
downloadydb-fb18373884e263729ed2c491b938573b1ff2bc71.tar.gz
Configurable read buffer size limit KIKIMR-14803
ref:62542e5801ef59acfd22e20d653c555265c24133
-rw-r--r--ydb/core/protos/config.proto1
-rw-r--r--ydb/core/protos/flat_scheme_op.proto2
-rw-r--r--ydb/core/tx/datashard/import_s3.cpp2
3 files changed, 3 insertions, 2 deletions
diff --git a/ydb/core/protos/config.proto b/ydb/core/protos/config.proto
index c2d14559ff..8041d4f4c8 100644
--- a/ydb/core/protos/config.proto
+++ b/ydb/core/protos/config.proto
@@ -1413,6 +1413,7 @@ message TDataShardConfig {
optional uint64 TtlReadAheadLo = 13 [default = 524288];
optional uint64 TtlReadAheadHi = 14 [default = 1048576];
optional uint64 IdleMemCompactionIntervalSeconds = 15 [default = 60];
+ optional uint64 RestoreReadBufferSizeLimit = 16 [default = 268435456]; // 256 MB
}
message TSchemeShardConfig {
diff --git a/ydb/core/protos/flat_scheme_op.proto b/ydb/core/protos/flat_scheme_op.proto
index 8f6a0502c0..3f710d1270 100644
--- a/ydb/core/protos/flat_scheme_op.proto
+++ b/ydb/core/protos/flat_scheme_op.proto
@@ -871,7 +871,7 @@ message TS3Settings {
message TLimits {
optional uint32 ReadBatchSize = 1 [default = 8388608]; // 8 MB
optional uint32 MinWriteBatchSize = 2 [default = 5242880]; // 5 MB
- optional uint32 ReadBufferSizeLimit = 3 [default = 67108864]; // 64 MB
+ reserved 3; // ReadBufferSizeLimit
};
optional TLimits Limits = 100;
diff --git a/ydb/core/tx/datashard/import_s3.cpp b/ydb/core/tx/datashard/import_s3.cpp
index 571cb448aa..9227522c45 100644
--- a/ydb/core/tx/datashard/import_s3.cpp
+++ b/ydb/core/tx/datashard/import_s3.cpp
@@ -696,7 +696,7 @@ public:
, LogPrefix_(TStringBuilder() << "s3:" << TxId)
, Retries(task.GetNumberOfRetries())
, ReadBatchSize(task.GetS3Settings().GetLimits().GetReadBatchSize())
- , ReadBufferSizeLimit(task.GetS3Settings().GetLimits().GetReadBufferSizeLimit())
+ , ReadBufferSizeLimit(AppData()->DataShardConfig.GetRestoreReadBufferSizeLimit())
{
}