aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoruzhas <uzhas@ydb.tech>2023-09-05 16:14:57 +0300
committeruzhas <uzhas@ydb.tech>2023-09-05 17:41:29 +0300
commit254d54cbc60980a89382b36321e8a47bcddb62fb (patch)
treeea2db7ca0bfd87d68be544e4fb62f8cc93d58412
parent668d419cb2c5c0fe9a0827c904e6ae9895635e16 (diff)
downloadydb-254d54cbc60980a89382b36321e8a47bcddb62fb.tar.gz
fix coverity issue: use after move
-rw-r--r--ydb/core/tx/columnshard/blob_manager.cpp2
-rw-r--r--ydb/core/tx/columnshard/blob_manager.h4
-rw-r--r--ydb/core/tx/columnshard/columnshard__export.cpp2
-rw-r--r--ydb/core/tx/columnshard/columnshard__init.cpp2
4 files changed, 5 insertions, 5 deletions
diff --git a/ydb/core/tx/columnshard/blob_manager.cpp b/ydb/core/tx/columnshard/blob_manager.cpp
index 361ff00619..056fb528d7 100644
--- a/ydb/core/tx/columnshard/blob_manager.cpp
+++ b/ydb/core/tx/columnshard/blob_manager.cpp
@@ -585,7 +585,7 @@ bool TBlobManager::DropOneToOne(const TUnifiedBlobId& blobId, IBlobManagerDb& db
return true;
}
-bool TBlobManager::UpdateOneToOne(TEvictedBlob&& evict, IBlobManagerDb& db, bool& dropped) {
+bool TBlobManager::UpdateOneToOne(TEvictedBlob& evict, IBlobManagerDb& db, bool& dropped) {
TEvictMetadata meta;
TEvictedBlob old{.Blob = evict.Blob};
diff --git a/ydb/core/tx/columnshard/blob_manager.h b/ydb/core/tx/columnshard/blob_manager.h
index cdcd6dac5c..00c77bd470 100644
--- a/ydb/core/tx/columnshard/blob_manager.h
+++ b/ydb/core/tx/columnshard/blob_manager.h
@@ -93,7 +93,7 @@ public:
// Lazily export blob to external object store. Keep it available via blobId.
virtual bool ExportOneToOne(TEvictedBlob&& evict, const TEvictMetadata& meta, IBlobManagerDb& db) = 0;
virtual bool DropOneToOne(const TUnifiedBlobId& blobId, IBlobManagerDb& db) = 0;
- virtual bool UpdateOneToOne(TEvictedBlob&& evict, IBlobManagerDb& db, bool& dropped) = 0;
+ virtual bool UpdateOneToOne(TEvictedBlob& evict, IBlobManagerDb& db, bool& dropped) = 0;
virtual bool EraseOneToOne(const TEvictedBlob& evict, IBlobManagerDb& db) = 0;
virtual bool LoadOneToOneExport(IBlobManagerDb& db, THashSet<TUnifiedBlobId>& droppedEvicting) = 0;
virtual TEvictedBlob GetEvicted(const TUnifiedBlobId& blob, TEvictMetadata& meta) = 0;
@@ -245,7 +245,7 @@ public:
// Implementation of IBlobExporter
bool ExportOneToOne(TEvictedBlob&& evict, const TEvictMetadata& meta, IBlobManagerDb& db) override;
bool DropOneToOne(const TUnifiedBlobId& blob, IBlobManagerDb& db) override;
- bool UpdateOneToOne(TEvictedBlob&& evict, IBlobManagerDb& db, bool& dropped) override;
+ bool UpdateOneToOne(TEvictedBlob& evict, IBlobManagerDb& db, bool& dropped) override;
bool EraseOneToOne(const TEvictedBlob& evict, IBlobManagerDb& db) override;
bool LoadOneToOneExport(IBlobManagerDb& db, THashSet<TUnifiedBlobId>& droppedEvicting) override;
TEvictedBlob GetEvicted(const TUnifiedBlobId& blobId, TEvictMetadata& meta) override;
diff --git a/ydb/core/tx/columnshard/columnshard__export.cpp b/ydb/core/tx/columnshard/columnshard__export.cpp
index 43e9934682..b74cafade3 100644
--- a/ydb/core/tx/columnshard/columnshard__export.cpp
+++ b/ydb/core/tx/columnshard/columnshard__export.cpp
@@ -64,7 +64,7 @@ bool TTxExportFinish::Execute(TTransactionContext& txc, const TActorContext&) {
.Blob = blobId,
.ExternBlob = externId
};
- bool present = Self->BlobManager->UpdateOneToOne(std::move(evict), blobManagerDb, dropped);
+ bool present = Self->BlobManager->UpdateOneToOne(evict, blobManagerDb, dropped);
// Delayed erase of evicted blob. Blob could be already deleted.
if (present && !dropped) {
diff --git a/ydb/core/tx/columnshard/columnshard__init.cpp b/ydb/core/tx/columnshard/columnshard__init.cpp
index 5d1c750185..392d294809 100644
--- a/ydb/core/tx/columnshard/columnshard__init.cpp
+++ b/ydb/core/tx/columnshard/columnshard__init.cpp
@@ -157,7 +157,7 @@ bool TTxInit::ReadEverything(TTransactionContext& txc, const TActorContext& ctx)
}
bool dropped;
- bool present = Self->BlobManager->UpdateOneToOne(std::move(evict), blobManagerDb, dropped);
+ bool present = Self->BlobManager->UpdateOneToOne(evict, blobManagerDb, dropped);
if (present) {
strBlobs += "'" + evict.Blob.ToStringNew() + "' ";
} else {