diff options
author | shakurov <shakurov@yandex-team.com> | 2023-10-06 23:31:29 +0300 |
---|---|---|
committer | shakurov <shakurov@yandex-team.com> | 2023-10-06 23:52:22 +0300 |
commit | a88c2f4d4d4d81fc52cfe6f6896fb8a3f79a248d (patch) | |
tree | f374e515d87e86ab7f613cd3a4bbc1456a1e1f65 | |
parent | 15ed9da722f2e75e60388f8d1c275a227af7f4cc (diff) | |
download | ydb-a88c2f4d4d4d81fc52cfe6f6896fb8a3f79a248d.tar.gz |
Remove the 'Reentrant call to ScheduleRequestsFromQueue' alert.
-rw-r--r-- | yt/yt/core/rpc/service_detail.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/yt/yt/core/rpc/service_detail.cpp b/yt/yt/core/rpc/service_detail.cpp index a8782cb86ed..e84b1ca06dd 100644 --- a/yt/yt/core/rpc/service_detail.cpp +++ b/yt/yt/core/rpc/service_detail.cpp @@ -1286,17 +1286,13 @@ void TRequestQueue::OnRequestFinished() } // Prevents reentrant invocations. +// One case is: RunRequest calling the handler synchronously, which replies the +// context, which calls context->Finish, and we're back here again. static thread_local bool ScheduleRequestsLatch = false; void TRequestQueue::ScheduleRequestsFromQueue() { - // COMPAT(shakurov): remove the latch after making sure it's unnecessary. if (ScheduleRequestsLatch) { - const auto& Logger = Service_ ? Service_->Logger : NLogging::TLogger(); - YT_LOG_ALERT("Reentrant call to TRequestQueue::ScheduleRequestsFromQueue detected (ServiceId: %v, Method: %v, Queue: %v)", - Service_ ? Service_->GetServiceId() : TServiceId(), - RuntimeInfo_ ? RuntimeInfo_->Descriptor.Method : TString(), - GetName()); return; } |