aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoruzhas <uzhas@ydb.tech>2022-11-23 13:21:13 +0300
committeruzhas <uzhas@ydb.tech>2022-11-23 13:21:13 +0300
commit90ab819c45e25b684b4bb46ba3aa8860e0972bb1 (patch)
tree8df690c7a7c6f54eb0b2a6a8e6d8b1eb0b95cf0a
parentcaf24070c3ecf8d3dfb071b2147e9afe89a4e1ac (diff)
downloadydb-90ab819c45e25b684b4bb46ba3aa8860e0972bb1.tar.gz
fix coverity issues in kqp_read_actor.cpp
-rw-r--r--ydb/core/kqp/runtime/kqp_read_actor.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/ydb/core/kqp/runtime/kqp_read_actor.cpp b/ydb/core/kqp/runtime/kqp_read_actor.cpp
index 47c494edc3e..1ab35d1b82d 100644
--- a/ydb/core/kqp/runtime/kqp_read_actor.cpp
+++ b/ydb/core/kqp/runtime/kqp_read_actor.cpp
@@ -215,7 +215,7 @@ public:
};
public:
- TKqpReadActor(NKikimrTxDataShard::TKqpReadRangesSourceSettings settings, NYql::NDq::TDqAsyncIoFactory::TSourceArguments args)
+ TKqpReadActor(NKikimrTxDataShard::TKqpReadRangesSourceSettings&& settings, const NYql::NDq::TDqAsyncIoFactory::TSourceArguments& args)
: Settings(std::move(settings))
, LogPrefix(TStringBuilder() << "SelfId: " << this->SelfId() << ", TxId: " << args.TxId << ", task: " << args.TaskId << ". ")
, ComputeActorId(args.ComputeActorId)
@@ -806,7 +806,7 @@ private:
THashMap<ui64, TVector<ui32>> ReadIdByTabletId;
THashMap<ui64, TShardState*> ResolveShards;
- ui64 ResolveShardId;
+ ui64 ResolveShardId = 0;
TShardQueue InFlightShards;
TShardQueue PendingShards;
@@ -829,8 +829,8 @@ private:
const TString LogPrefix;
TTableId TableId;
- TActorId ComputeActorId;
- ui64 InputIndex;
+ const TActorId ComputeActorId;
+ const ui64 InputIndex;
const NMiniKQL::TTypeEnvironment& TypeEnv;
const NMiniKQL::THolderFactory& HolderFactory;
};
@@ -839,7 +839,7 @@ private:
void RegisterKqpReadActor(NYql::NDq::TDqAsyncIoFactory& factory) {
factory.RegisterSource<NKikimrTxDataShard::TKqpReadRangesSourceSettings>(
TString(NYql::KqpReadRangesSourceName),
- [] (NKikimrTxDataShard::TKqpReadRangesSourceSettings&& settings, NYql::NDq::TDqAsyncIoFactory::TSourceArguments args) {
+ [] (NKikimrTxDataShard::TKqpReadRangesSourceSettings&& settings, NYql::NDq::TDqAsyncIoFactory::TSourceArguments&& args) {
auto* actor = new TKqpReadActor(std::move(settings), args);
return std::make_pair<NYql::NDq::IDqComputeActorAsyncInput*, IActor*>(actor, actor);
});