aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoruzhas <uzhas@ydb.tech>2022-09-10 13:47:21 +0300
committeruzhas <uzhas@ydb.tech>2022-09-10 13:47:21 +0300
commit6fe7662782934b99b36ae141cb934415a6b69f6c (patch)
tree3aa8e68b0821c852572688dac43a0a44c2d33b68
parentefecd0b9a7144d4972bdd0a36962f21efaeeb774 (diff)
downloadydb-6fe7662782934b99b36ae141cb934415a6b69f6c.tar.gz
enable precomputes
-rw-r--r--ydb/core/yq/libs/actors/run_actor.cpp2
-rw-r--r--ydb/core/yq/libs/gateway/empty_gateway.cpp2
-rw-r--r--ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp4
3 files changed, 4 insertions, 4 deletions
diff --git a/ydb/core/yq/libs/actors/run_actor.cpp b/ydb/core/yq/libs/actors/run_actor.cpp
index 02663d05e1f..d5b43a8cd71 100644
--- a/ydb/core/yq/libs/actors/run_actor.cpp
+++ b/ydb/core/yq/libs/actors/run_actor.cpp
@@ -1312,7 +1312,7 @@ private:
apply("MaxTasksPerOperation", ToString(MaxTasksPerOperation));
apply("EnableComputeActor", "1");
apply("ComputeActorType", "async");
- apply("_EnablePrecompute", "0"); // TODO: enable together with removing TEmptyGateway
+ apply("_EnablePrecompute", "1");
switch (Params.QueryType) {
case YandexQuery::QueryContent::STREAMING: {
diff --git a/ydb/core/yq/libs/gateway/empty_gateway.cpp b/ydb/core/yq/libs/gateway/empty_gateway.cpp
index 305852e663c..bc145f74eb4 100644
--- a/ydb/core/yq/libs/gateway/empty_gateway.cpp
+++ b/ydb/core/yq/libs/gateway/empty_gateway.cpp
@@ -64,7 +64,7 @@ public:
auto result = NThreading::NewPromise<NYql::IDqGateway::TResult>();
auto event = MakeHolder<TEvents::TEvGraphParams>(params);
- event->IsEvaluation = queryParams.Value("Evaluation", "") == "true";
+ event->IsEvaluation = FromString<bool>(queryParams.Value("Evaluation", "false")) || FromString<bool>(queryParams.Value("Precompute", "false"));
event->Result = result;
NActors::TActivationContext::Send(new NActors::IEventHandle(RunActorId, {}, event.Release()));
diff --git a/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp b/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
index 6f9ca48e39e..c5427cdeff1 100644
--- a/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
+++ b/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
@@ -789,7 +789,7 @@ private:
future = NThreading::MakeFuture<IDqGateway::TResult>(std::move(result));
}
} else {
- graphParams["Evaluation"] = ctx.Step.IsDone(TExprStep::ExprEval) ? "false" : "true";
+ graphParams["Evaluation"] = ToString(!ctx.Step.IsDone(TExprStep::ExprEval));
future = State->DqGateway->ExecutePlan(
State->SessionId, executionPlanner->GetPlan(), columns, secureParams, graphParams,
settings, progressWriter, ModulesMapping, fillSettings.Discard);
@@ -1591,7 +1591,7 @@ private:
}
auto graphParams = GatherGraphParams(optimizedInput);
-
+ graphParams["Precompute"] = ToString(true);
MarkProgressStarted(publicIds->AllPublicIds, State->ProgressWriter);
IDqGateway::TDqProgressWriter progressWriter = MakeDqProgressWriter(publicIds);