diff options
author | uzhas <[email protected]> | 2023-07-17 11:57:50 +0300 |
---|---|---|
committer | uzhas <[email protected]> | 2023-07-17 11:57:50 +0300 |
commit | 5e0f4b1b36814db524e00584ab22c83171da1b30 (patch) | |
tree | 7cbe77fd2f8a8a57021987abbc3d279f50211821 | |
parent | e35773bee422606cdda1417f88debe0b19de78bf (diff) |
normalize external table attributes, enable test_timestamp_simple_posix @ v2
-rw-r--r-- | ydb/core/external_sources/external_source.h | 4 | ||||
-rw-r--r-- | ydb/core/external_sources/object_storage.cpp | 2 | ||||
-rw-r--r-- | ydb/core/kqp/provider/yql_kikimr_datasource.cpp | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/ydb/core/external_sources/external_source.h b/ydb/core/external_sources/external_source.h index 763fdea0ba0..bc5162b4ad1 100644 --- a/ydb/core/external_sources/external_source.h +++ b/ydb/core/external_sources/external_source.h @@ -16,7 +16,7 @@ struct IExternalSource : public TThrRefBase { Packs TSchema, TGeneral into some string in arbitrary format: proto, json, text, and others. The output returns a string called content. Further, this string will be stored inside. - After that, it is passed to the GetParamters method. + After that, it is passed to the GetParameters method. Can throw an exception in case of an error. */ virtual TString Pack(const NKikimrExternalSources::TSchema& schema, @@ -35,7 +35,7 @@ struct IExternalSource : public TThrRefBase { this data will be displayed in the viewer. Can throw an exception in case of an error */ - virtual TMap<TString, TString> GetParamters(const TString& content) const = 0; + virtual TMap<TString, TString> GetParameters(const TString& content) const = 0; }; } diff --git a/ydb/core/external_sources/object_storage.cpp b/ydb/core/external_sources/object_storage.cpp index 86dacb43a35..c12eae2b7fe 100644 --- a/ydb/core/external_sources/object_storage.cpp +++ b/ydb/core/external_sources/object_storage.cpp @@ -50,7 +50,7 @@ struct TObjectStorageExternalSource : public IExternalSource { return TString{NYql::S3ProviderName}; } - virtual TMap<TString, TString> GetParamters(const TString& content) const override { + virtual TMap<TString, TString> GetParameters(const TString& content) const override { NKikimrExternalSources::TObjectStorage objectStorage; objectStorage.ParseFromStringOrThrow(content); diff --git a/ydb/core/kqp/provider/yql_kikimr_datasource.cpp b/ydb/core/kqp/provider/yql_kikimr_datasource.cpp index a1e60932175..617c24a2c70 100644 --- a/ydb/core/kqp/provider/yql_kikimr_datasource.cpp +++ b/ydb/core/kqp/provider/yql_kikimr_datasource.cpp @@ -565,8 +565,8 @@ public: auto userSchema = ctx.NewAtom(pos, "userschema"sv); items.emplace_back(ctx.NewList(pos, {userSchema, type, order})); - for (const auto& [key, value]: source->GetParamters(content)) { - auto keyAtom = ctx.NewAtom(pos, key); + for (const auto& [key, value]: source->GetParameters(content)) { + auto keyAtom = ctx.NewAtom(pos, NormalizeName(key)); auto valueAtom = ctx.NewAtom(pos, value); items.emplace_back(ctx.NewList(pos, {keyAtom, valueAtom})); } |