aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorivanmorozov <ivanmorozov@yandex-team.com>2023-07-22 13:37:34 +0300
committerivanmorozov <ivanmorozov@yandex-team.com>2023-07-22 13:37:34 +0300
commit4f35e8236121414a749e89b6a1be9bc328994356 (patch)
tree74095c791f30e3a4235e4622e3cbcdab5e564b78
parent4efbd184ae7df23cb21866c1dca53f02da01921b (diff)
downloadydb-4f35e8236121414a749e89b6a1be9bc328994356.tar.gz
KIKIMR-18796: small fixes and prevent guard alert on actors cleaning
-rw-r--r--ydb/core/tx/columnshard/engines/index_logic_logs.h4
-rw-r--r--ydb/core/tx/columnshard/engines/writer/compacted_blob_constructor.h9
2 files changed, 9 insertions, 4 deletions
diff --git a/ydb/core/tx/columnshard/engines/index_logic_logs.h b/ydb/core/tx/columnshard/engines/index_logic_logs.h
index 7fe89b92e8c..3b13506a5da 100644
--- a/ydb/core/tx/columnshard/engines/index_logic_logs.h
+++ b/ydb/core/tx/columnshard/engines/index_logic_logs.h
@@ -39,10 +39,10 @@ public:
}
Counters.CompactionInputSize(readBytes);
}
- const TInstant start = TInstant::Now();
+ const TMonotonic start = TMonotonic::Now();
TConclusion<std::vector<TString>> result = DoApply(indexChanges);
if (result.IsSuccess()) {
- Counters.CompactionDuration->Collect((TInstant::Now() - start).MilliSeconds());
+ Counters.CompactionDuration->Collect((TMonotonic::Now() - start).MilliSeconds());
} else {
Counters.CompactionFails->Add(1);
}
diff --git a/ydb/core/tx/columnshard/engines/writer/compacted_blob_constructor.h b/ydb/core/tx/columnshard/engines/writer/compacted_blob_constructor.h
index eff8b3a86ba..08d22b7c2ca 100644
--- a/ydb/core/tx/columnshard/engines/writer/compacted_blob_constructor.h
+++ b/ydb/core/tx/columnshard/engines/writer/compacted_blob_constructor.h
@@ -46,10 +46,15 @@ private:
TAutoPtr<NColumnShard::TEvPrivate::TEvWriteIndex> WriteIndexEv;
std::shared_ptr<TBlobsConstructor> BlobConstructor;
TActorId DstActor;
+protected:
+ void DoOnReadyResult(const NActors::TActorContext& ctx, const NColumnShard::TBlobPutResult::TPtr& putResult) override;
public:
TCompactedWriteController(const TActorId& dstActor, TAutoPtr<NColumnShard::TEvPrivate::TEvWriteIndex> writeEv, bool blobGrouppingEnabled);
-
- void DoOnReadyResult(const NActors::TActorContext& ctx, const NColumnShard::TBlobPutResult::TPtr& putResult) override;
+ ~TCompactedWriteController() {
+ if (WriteIndexEv && WriteIndexEv->IndexChanges) {
+ WriteIndexEv->IndexChanges->AbortEmergency();
+ }
+ }
NOlap::IBlobConstructor::TPtr GetBlobConstructor() override {
return BlobConstructor;