summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhcpp <[email protected]>2023-07-03 19:15:24 +0300
committerhcpp <[email protected]>2023-07-03 19:15:24 +0300
commit37d4b82bc45a3899311867bccf13db6bdd90d472 (patch)
tree82cf36423bd4020111ebe52c9315f1feca860ad3
parentcd4083c6c12395f3f5ee5a5dde107196144bc735 (diff)
cleanup and fixes
-rw-r--r--ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp4
-rw-r--r--ydb/core/fq/libs/compute/ydb/events/events.h28
2 files changed, 16 insertions, 16 deletions
diff --git a/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp b/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp
index 1881a49e2a6..46d0ebd6184 100644
--- a/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp
+++ b/ydb/core/fq/libs/compute/ydb/control_plane/compute_database_control_plane_service.cpp
@@ -51,8 +51,8 @@ public:
)
void Handle(TEvControlPlaneStorage::TEvDescribeDatabaseResponse::TPtr& ev) {
- const auto issues = ev->Get()->Issues;
- const auto result = ev->Get()->Record;
+ const auto& issues = ev->Get()->Issues;
+ const auto& result = ev->Get()->Record;
if (issues && issues.back().IssueCode == TIssuesIds::ACCESS_DENIED) {
Send(DatabaseClientActorId, new TEvYdbCompute::TEvCreateDatabaseRequest{Request->Get()->CloudId, Request->Get()->Scope, Request->Get()->BasePath, Request->Get()->Path});
diff --git a/ydb/core/fq/libs/compute/ydb/events/events.h b/ydb/core/fq/libs/compute/ydb/events/events.h
index c593c9af0f9..0b3957405df 100644
--- a/ydb/core/fq/libs/compute/ydb/events/events.h
+++ b/ydb/core/fq/libs/compute/ydb/events/events.h
@@ -58,7 +58,7 @@ struct TEvYdbCompute {
struct TEvExecuteScriptResponse : public NActors::TEventLocal<TEvExecuteScriptResponse, EvExecuteScriptResponse> {
TEvExecuteScriptResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -84,13 +84,13 @@ struct TEvYdbCompute {
struct TEvGetOperationResponse : public NActors::TEventLocal<TEvGetOperationResponse, EvGetOperationResponse> {
TEvGetOperationResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
TEvGetOperationResponse(NYdb::NQuery::EExecStatus execStatus, NYql::TIssues issues)
: ExecStatus(execStatus)
- , Issues(issues)
+ , Issues(std::move(issues))
, Status(NYdb::EStatus::SUCCESS)
{}
@@ -113,7 +113,7 @@ struct TEvYdbCompute {
struct TEvFetchScriptResultResponse : public NActors::TEventLocal<TEvFetchScriptResultResponse, EvFetchScriptResultResponse> {
TEvFetchScriptResultResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -137,7 +137,7 @@ struct TEvYdbCompute {
struct TEvCancelOperationResponse : public NActors::TEventLocal<TEvCancelOperationResponse, EvCancelOperationResponse> {
TEvCancelOperationResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -155,7 +155,7 @@ struct TEvYdbCompute {
struct TEvForgetOperationResponse : public NActors::TEventLocal<TEvForgetOperationResponse, EvForgetOperationResponse> {
TEvForgetOperationResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -190,7 +190,7 @@ struct TEvYdbCompute {
{}
explicit TEvCreateDatabaseResponse(NYql::TIssues issues)
- : Issues(issues)
+ : Issues(std::move(issues))
{}
TEvCreateDatabaseResponse(const FederatedQuery::Internal::ComputeDatabaseInternal& result)
@@ -208,9 +208,9 @@ struct TEvYdbCompute {
, Success(true)
{}
- explicit TEvExecuterResponse(const NYql::TIssues& issues)
+ explicit TEvExecuterResponse(NYql::TIssues issues)
: Success(false)
- , Issues(issues)
+ , Issues(std::move(issues))
{}
NYdb::TOperation::TOperationId OperationId;
@@ -221,7 +221,7 @@ struct TEvYdbCompute {
struct TEvStatusTrackerResponse : public NActors::TEventLocal<TEvStatusTrackerResponse, EvStatusTrackerResponse> {
TEvStatusTrackerResponse(NYql::TIssues issues, NYdb::EStatus status, NYdb::NQuery::EExecStatus execStatus)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
, ExecStatus(execStatus)
{}
@@ -233,7 +233,7 @@ struct TEvYdbCompute {
struct TEvResultWriterResponse : public NActors::TEventLocal<TEvResultWriterResponse, EvResultWriterResponse> {
TEvResultWriterResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -243,7 +243,7 @@ struct TEvYdbCompute {
struct TEvResourcesCleanerResponse : public NActors::TEventLocal<TEvResourcesCleanerResponse, EvResourcesCleanerResponse> {
TEvResourcesCleanerResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -253,7 +253,7 @@ struct TEvYdbCompute {
struct TEvFinalizerResponse : public NActors::TEventLocal<TEvFinalizerResponse, EvFinalizerResponse> {
TEvFinalizerResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}
@@ -263,7 +263,7 @@ struct TEvYdbCompute {
struct TEvStopperResponse : public NActors::TEventLocal<TEvStopperResponse, EvStopperResponse> {
TEvStopperResponse(NYql::TIssues issues, NYdb::EStatus status)
- : Issues(issues)
+ : Issues(std::move(issues))
, Status(status)
{}