summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorulya-sidorina <[email protected]>2023-02-15 15:00:54 +0300
committerulya-sidorina <[email protected]>2023-02-15 15:00:54 +0300
commit2ad5718c0cbcb0066f3c36421d63a54c19bb4c1d (patch)
tree0af42e2ae8d5119dda50a4a6a01b7847ef9fea9b
parent8453fb8a13798fc248cbf65e75a559da7c2ffc9d (diff)
disable stream lookup for points
fix(kqp): disable stream lookup for points
-rw-r--r--ydb/core/kqp/compile_service/kqp_compile_actor.cpp1
-rw-r--r--ydb/core/kqp/opt/logical/kqp_opt_log_ranges.cpp2
-rw-r--r--ydb/core/kqp/provider/yql_kikimr_settings.h1
-rw-r--r--ydb/core/kqp/ut/opt/kqp_ne_ut.cpp1
-rw-r--r--ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp2
-rw-r--r--ydb/core/protos/config.proto1
6 files changed, 6 insertions, 2 deletions
diff --git a/ydb/core/kqp/compile_service/kqp_compile_actor.cpp b/ydb/core/kqp/compile_service/kqp_compile_actor.cpp
index 34378f304ce..8a7e8515827 100644
--- a/ydb/core/kqp/compile_service/kqp_compile_actor.cpp
+++ b/ydb/core/kqp/compile_service/kqp_compile_actor.cpp
@@ -342,6 +342,7 @@ void ApplyServiceConfig(TKikimrConfiguration& kqpConfig, const TTableServiceConf
kqpConfig.EnableKqpScanQuerySourceRead = serviceConfig.GetEnableKqpScanQuerySourceRead();
kqpConfig.EnableKqpDataQueryStreamLookup = serviceConfig.GetEnableKqpDataQueryStreamLookup();
kqpConfig.EnableKqpScanQueryStreamLookup = serviceConfig.GetEnableKqpScanQueryStreamLookup();
+ kqpConfig.EnableKqpDataQueryStreamPointLookup = serviceConfig.GetEnableKqpDataQueryStreamPointLookup();
}
IActor* CreateKqpCompileActor(const TActorId& owner, const TKqpSettings::TConstPtr& kqpSettings,
diff --git a/ydb/core/kqp/opt/logical/kqp_opt_log_ranges.cpp b/ydb/core/kqp/opt/logical/kqp_opt_log_ranges.cpp
index f60b6983885..85a8af7b513 100644
--- a/ydb/core/kqp/opt/logical/kqp_opt_log_ranges.cpp
+++ b/ydb/core/kqp/opt/logical/kqp_opt_log_ranges.cpp
@@ -247,7 +247,7 @@ TExprBase KqpPushPredicateToReadTable(TExprBase node, TExprContext& ctx, const T
.Index(indexName.Cast())
.Done();
} else {
- if (kqpCtx.Config->EnableKqpDataQueryStreamLookup) {
+ if (kqpCtx.Config->EnableKqpDataQueryStreamPointLookup) {
readInput = Build<TKqlStreamLookupTable>(ctx, read.Pos())
.Table(read.Table())
.LookupKeys(lookupKeys)
diff --git a/ydb/core/kqp/provider/yql_kikimr_settings.h b/ydb/core/kqp/provider/yql_kikimr_settings.h
index 3ec772576b5..a78371ee5d2 100644
--- a/ydb/core/kqp/provider/yql_kikimr_settings.h
+++ b/ydb/core/kqp/provider/yql_kikimr_settings.h
@@ -133,6 +133,7 @@ struct TKikimrConfiguration : public TKikimrSettings, public NCommon::TSettingDi
bool EnableKqpDataQuerySourceRead = false;
bool EnableKqpScanQueryStreamLookup = false;
bool EnableKqpDataQueryStreamLookup = false;
+ bool EnableKqpDataQueryStreamPointLookup = false;
};
}
diff --git a/ydb/core/kqp/ut/opt/kqp_ne_ut.cpp b/ydb/core/kqp/ut/opt/kqp_ne_ut.cpp
index fd01b00699f..bc650bb7301 100644
--- a/ydb/core/kqp/ut/opt/kqp_ne_ut.cpp
+++ b/ydb/core/kqp/ut/opt/kqp_ne_ut.cpp
@@ -3319,6 +3319,7 @@ Y_UNIT_TEST_SUITE(KqpNewEngine) {
Y_UNIT_TEST(StreamLookupForDataQuery) {
NKikimrConfig::TAppConfig appConfig;
appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(true);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamPointLookup(true);
TKikimrRunner kikimr(TKikimrSettings().SetAppConfig(appConfig));
auto db = kikimr.GetTableClient();
auto session = db.CreateSession().GetValueSync().GetSession();
diff --git a/ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp b/ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp
index 4d61e31db3e..94f86a78970 100644
--- a/ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp
+++ b/ydb/core/kqp/ut/perf/kqp_query_perf_ut.cpp
@@ -122,7 +122,7 @@ TParams BuildInsertIndexParams(TTableClient& client) {
Y_UNIT_TEST_SUITE(KqpQueryPerf) {
Y_UNIT_TEST_TWIN(KvRead, EnableStreamLookup) {
NKikimrConfig::TAppConfig appConfig;
- appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamLookup(EnableStreamLookup);
+ appConfig.MutableTableServiceConfig()->SetEnableKqpDataQueryStreamPointLookup(EnableStreamLookup);
auto settings = TKikimrSettings()
.SetAppConfig(appConfig);
TKikimrRunner kikimr{settings};
diff --git a/ydb/core/protos/config.proto b/ydb/core/protos/config.proto
index 89872c4accd..037b7e033d0 100644
--- a/ydb/core/protos/config.proto
+++ b/ydb/core/protos/config.proto
@@ -1237,6 +1237,7 @@ message TTableServiceConfig {
optional bool EnableKqpScanQueryStreamLookup = 30 [default = false];
optional bool EnableKqpDataQueryStreamLookup = 31 [default = false];
optional uint32 ExecuterDelayToRetryMs = 32 [default = 400];
+ optional bool EnableKqpDataQueryStreamPointLookup = 33 [default = false];
};
// Config describes immediate controls and allows