aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoreeight <eeight@yandex-team.ru>2022-04-23 16:31:19 +0300
committereeight <eeight@yandex-team.ru>2022-04-23 16:31:19 +0300
commit252ba6ab06781bbdf24af20d7119f1c778f1a834 (patch)
tree129da22c0fba85baab01721f04f06f76b61099ed
parent73f99a9ddfdf9563f08ea6054fb2380f78e9dac5 (diff)
downloadydb-252ba6ab06781bbdf24af20d7119f1c778f1a834.tar.gz
IGNIETFERRO-1969 Prepare to enable -Wrange-loop-construct
ref:75a3d35c2e4ac07714682c2b42da0719f2a49412
-rw-r--r--ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp26
1 files changed, 13 insertions, 13 deletions
diff --git a/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp b/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
index 9a985d4d521..72ae80e30a1 100644
--- a/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
+++ b/ydb/library/yql/minikql/comp_nodes/ut/mkql_wide_combine_ut.cpp
@@ -593,7 +593,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(stringI8Samples.size(), items));
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[0] = NUdf::TUnboxedValuePod::Embedded(sample.first);
@@ -625,7 +625,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
std::unordered_map<std::string, std::array<double, 3U>> expects(201);
const auto t = TInstant::Now();
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, +1E7, -1E7}).first->second;
std::get<0U>(item) += sample.second;
std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -657,7 +657,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(stringI8Samples.size(), items));
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[0] = NUdf::TUnboxedValuePod::Embedded(sample.first);
@@ -691,7 +691,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
std::unordered_map<std::pair<ui32, std::string>, std::array<double, 3U>, TPairHash> expects;
const auto t = TInstant::Now();
- for (const auto sample : pairSamples) {
+ for (const auto& sample : pairSamples) {
auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, +1E7, -1E7}).first->second;
std::get<0U>(item) += sample.second;
std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -725,7 +725,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(pairSamples.size(), items));
- for (const auto sample : pairSamples) {
+ for (const auto& sample : pairSamples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[1] = NUdf::TUnboxedValuePod(sample.second);
@@ -823,7 +823,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(TpchSamples.size(), items));
- for (const auto sample : TpchSamples) {
+ for (const auto& sample : TpchSamples) {
NUdf::TUnboxedValue* elements = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(7U, elements);
elements[0] = NUdf::TUnboxedValuePod(std::get<0U>(sample));
@@ -1405,7 +1405,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
std::unordered_map<std::string, double> expects(201);
const auto t = TInstant::Now();
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
expects.emplace(sample.first, 0.0).first->second += sample.second;
}
const auto cppTime = TInstant::Now() - t;
@@ -1434,7 +1434,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(stringI8Samples.size(), items));
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[0] = NUdf::TUnboxedValuePod::Embedded(sample.first);
@@ -1466,7 +1466,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
std::unordered_map<std::string, std::array<double, 3U>> expects(201);
const auto t = TInstant::Now();
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, +1E7, -1E7}).first->second;
std::get<0U>(item) += sample.second;
std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -1498,7 +1498,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(stringI8Samples.size(), items));
- for (const auto sample : stringI8Samples) {
+ for (const auto& sample : stringI8Samples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[0] = NUdf::TUnboxedValuePod::Embedded(sample.first);
@@ -1532,7 +1532,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
std::unordered_map<std::pair<ui32, std::string>, std::array<double, 3U>, TPairHash> expects;
const auto t = TInstant::Now();
- for (const auto sample : pairSamples) {
+ for (const auto& sample : pairSamples) {
auto& item = expects.emplace(sample.first, std::array<double, 3U>{0.0, +1E7, -1E7}).first->second;
std::get<0U>(item) += sample.second;
std::get<1U>(item) = std::min(std::get<1U>(item), sample.second);
@@ -1566,7 +1566,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(pairSamples.size(), items));
- for (const auto sample : pairSamples) {
+ for (const auto& sample : pairSamples) {
NUdf::TUnboxedValue* pair = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(2U, pair);
pair[1] = NUdf::TUnboxedValuePod(sample.second);
@@ -1664,7 +1664,7 @@ Y_UNIT_TEST_SUITE(TMiniKQLWideLastCombinerPerfTest) {
const auto graph = setup.BuildGraph(pgmReturn, {list});
NUdf::TUnboxedValue* items = nullptr;
graph->GetEntryPoint(0, true)->SetValue(graph->GetContext(), graph->GetHolderFactory().CreateDirectArrayHolder(TpchSamples.size(), items));
- for (const auto sample : TpchSamples) {
+ for (const auto& sample : TpchSamples) {
NUdf::TUnboxedValue* elements = nullptr;
*items++ = graph->GetHolderFactory().CreateDirectArrayHolder(7U, elements);
elements[0] = NUdf::TUnboxedValuePod(std::get<0U>(sample));