aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorva-kuznecov <va-kuznecov@ydb.tech>2022-12-15 15:56:40 +0300
committerva-kuznecov <va-kuznecov@ydb.tech>2022-12-15 15:56:40 +0300
commitb0756cd49efba4719aecd33c0b442ad22dbf4aa2 (patch)
tree4e618e8e246d83d1d2a8c909a6fc342d8fd0289b
parent8fa1858c09c18e80c3b95d302a81a7d0cc38ba30 (diff)
downloadydb-b0756cd49efba4719aecd33c0b442ad22dbf4aa2.tar.gz
Remove unused DeviceLatency
-rw-r--r--ydb/core/load_test/events.h1
-rw-r--r--ydb/core/load_test/pdisk_read.cpp3
-rw-r--r--ydb/core/load_test/pdisk_write.cpp11
3 files changed, 0 insertions, 15 deletions
diff --git a/ydb/core/load_test/events.h b/ydb/core/load_test/events.h
index 8b84db914d..05bc60ce88 100644
--- a/ydb/core/load_test/events.h
+++ b/ydb/core/load_test/events.h
@@ -34,7 +34,6 @@ struct TEvLoad {
TVector<ui64> RwSpeedBps;
ELoadType LoadType;
NMonitoring::TPercentileTrackerLg<10, 4, 1> LatencyUs; // Upper threshold of this tracker is ~134 seconds, size is 256kB
- TMap<double, ui64> DeviceLatency;
double GetAverageSpeed() const {
if (RwSpeedBps.size() < 1) {
diff --git a/ydb/core/load_test/pdisk_read.cpp b/ydb/core/load_test/pdisk_read.cpp
index 55f440d730..17cdec05ab 100644
--- a/ydb/core/load_test/pdisk_read.cpp
+++ b/ydb/core/load_test/pdisk_read.cpp
@@ -465,9 +465,6 @@ public:
if (now > MeasurementStartTime) {
Report->LatencyUs.Increment((now - request->StartTime).MicroSeconds());
- for(const auto& perc : DevicePercentiles) {
- Report->DeviceLatency[perc.first] = Max(Report->DeviceLatency[perc.first], (ui64)*perc.second);
- }
}
TimeSeries.emplace(now, TRequestStat{
diff --git a/ydb/core/load_test/pdisk_write.cpp b/ydb/core/load_test/pdisk_write.cpp
index 21ef38a153..56ec5944b2 100644
--- a/ydb/core/load_test/pdisk_write.cpp
+++ b/ydb/core/load_test/pdisk_write.cpp
@@ -125,7 +125,6 @@ class TPDiskWriterLoadTestActor : public TActorBootstrapped<TPDiskWriterLoadTest
TIntrusivePtr<TEvLoad::TLoadReport> Report;
TIntrusivePtr<NMonitoring::TCounterForPtr> PDiskBytesWritten;
- TMap<double, TIntrusivePtr<NMonitoring::TCounterForPtr>> DevicePercentiles;
public:
static constexpr auto ActorActivityType() {
@@ -195,13 +194,6 @@ public:
TIntrusivePtr<::NMonitoring::TDynamicCounters> pDiskCounters = GetServiceCounters(counters, "pdisks")->
GetSubgroup("pdisk", Sprintf("%09" PRIu32, PDiskId));
PDiskBytesWritten = pDiskCounters->GetSubgroup("subsystem", "device")->GetCounter("DeviceBytesWritten", true);
- TIntrusivePtr<::NMonitoring::TDynamicCounters> percentilesGroup;
- percentilesGroup = pDiskCounters-> GetSubgroup("subsystem", "deviceWriteDuration")->GetSubgroup("sensor", "Time in microsec");
- for (double percentile : {0.1, 0.5, 0.9, 0.99, 0.999, 1.0}) {
- DevicePercentiles.emplace(percentile, percentilesGroup->GetNamedCounter("percentile",
- Sprintf("%.1f", percentile * 100.f)));
- }
-
if (Chunks.empty()) {
ythrow TLoadActorException() << "Chunks may not be empty";
@@ -515,9 +507,6 @@ public:
if (now > MeasurementStartTime) {
Report->LatencyUs.Increment((now - request->StartTime).MicroSeconds());
- for(const auto& perc : DevicePercentiles) {
- Report->DeviceLatency[perc.first] = Max(Report->DeviceLatency[perc.first], (ui64)*perc.second);
- }
}
TimeSeries.emplace(now, TRequestStat{