ydb/util, branch 22.2.38Mirror of YDB github reposhttps://code.mastervirt.ru/ydb/atom?h=22.2.382022-02-22T00:31:52Zrm unused include2022-02-22T00:31:52Ztobotobo@yandex-team.ru2022-02-22T00:31:52Zurn:sha1:75c99e1ca6e2eb6accf7c91127e4a76d346228f9
ref:f0f0572f52d7977841789105c6b51d4ca5ea1382
Properly attribute err.h replacements as [[noreturn]]2022-02-19T10:10:22Zthegeorgthegeorg@yandex-team.ru2022-02-19T10:10:22Zurn:sha1:7d7953cb46099a2517822b5832d49351eeecbde1
ref:e86419934a6858c3f36f45e15d1e42cc501ea395
pass string by reference, rm unused include2022-02-19T01:55:43Ztobotobo@yandex-team.ru2022-02-19T01:55:43Zurn:sha1:ac7edc66fd1503d44744fedde420ad08cdebd1a9
ref:b2a9abb354b18c7a8d339a26c1e23fba39e48c06
intermediate changes2022-02-18T12:49:59Zarcadia-devtoolsarcadia-devtools@yandex-team.ru2022-02-18T12:49:59Zurn:sha1:b4cb34dfb2619f594d82e512fd9ff7fc97400133
ref:1a0585d83f27cb6fb5b9c4f68a08177e10faf3b3
introduce util/digest/city_ut.cpp2022-02-18T08:43:49Zgleb-kovgleb-kov@yandex-team.ru2022-02-18T08:43:49Zurn:sha1:f7134d2525269ea8412b3bf0736239fbfd545a2e
ref:2bd6e26cda5245c96d0b2f3c326dd13e0827c326
IGNIETFERRO-1975, BIGRT-39 [RESUBMIT]: add TBackTrace::FromCurrentException() to CurrentExceptionMessage()2022-02-17T21:11:31Zsvkrasnovsvkrasnov@yandex-team.ru2022-02-17T21:11:31Zurn:sha1:5d9b03f7d5e4d38860ff05886839b0224222da3e
ref:8d5b72512d2b80cfd1ae859a4175cc92cf32a99a
[util] fix fstat for archive directories on windows2022-02-17T19:22:02Zkikhtkikht@yandex-team.ru2022-02-17T19:22:02Zurn:sha1:a4e5577781d9f1162779286558a90252430f6200
Currently TFileStat has a bunch of problems on Windows:
1. Mode computation ORs different types, but file attributes it checks are not mutually exclusive. E.g. it is possible for directory to have both `FILE_ATTRIBUTE_DIRECTORY` and `FILE_ATTRIBUTE_ARCHIVE`, but it will currently lead to invalid `_S_IFDIR | _S_IFREG` mode.
2. Any file with `FILE_ATTRIBUTE_REPARSE_POINT` flag is considered to be symlink. But there are many other types of reparse points even user-defined ones. For more info see https://docs.microsoft.com/en-us/windows/win32/fileio/reparse-point-tags
To fix all this we do the following:
1. Add `ReparseTag` field to `TSystemFStat` and fill it for reparse points in `GetStatByHandle`.
2. Refactor `GetWinFileType` out of `GetFileMode` to ensure that we always select only single `S_IFMT` value.
3. Pass reparse tag value into `GetWinFileType` and select `S_IFLNK` only for `IO_REPARSE_TAG_SYMLINK` and `IO_REPARSE_TAG_MOUNT_POINT` tags. The latter one is a bit strange, but this behaviour is aligned with current implementation of `WinReadLink`.
4. Factor `ReadReparsePoint` out of `WinReadLink`. This function uses `DeviceIoControl` to read reparse point data into structures copied from WDK.
5. Add `WinReadReparseTag` that uses `ReadReparsePoint` to extract reparse point tag. We use this approach instead of MSDN-recommended `FindFirstFile` because latter requires file path, but we have file handle at this point. AFAIK golang and python use similar approach for this.
6. Add test for archived directory case.
7. Make symlink nofollow tests run only when symlink creation is possible for current user.
Discovered in https://st.yandex-team.ru/ARC-3931
ref:4f6735817b9f85f3351a1021a56dd7eb4606bd65
TShellCommand::TImpl via TShellCommandOptions2022-02-17T12:58:20Zgleb-kovgleb-kov@yandex-team.ru2022-02-17T12:58:20Zurn:sha1:b3e69438ecdcb34935c6731682f072368e7eafda
ref:f149c0bc76521a1273f6a2c155f2bd116141b1eb
util unittests: replace try-catch-UNIT_ASSERT via UNIT_ASSERT_EXCEPTION2022-02-16T17:08:53Zgleb-kovgleb-kov@yandex-team.ru2022-02-16T17:08:53Zurn:sha1:76cbe125b7d39dca64a0de7b86eee37fd575e4df
ref:f59ddae7dbb42f5fa999e6071769f709e8b80b85
Rollback: r91450432022-02-15T19:49:52Zrobot-srch-releaserrobot-srch-releaser@yandex-team.ru2022-02-15T19:49:52Zurn:sha1:0bd0e5d1ab192e2782657cb05a36637ccb42ed57
[diff-resolver:svkrasnov] Sandbox task: https://sandbox.yandex-team.ru/task/1216524490/view
Task author: omakovski@
Description: Revert 9145043
Note: mandatory check (NEED_CHECK) was skipped
ref:dbe6517dcb523875d1e5de010069988b428c98bb