ydb/util/system/fstat_ut.cpp, branch oidc-1.2.3Mirror of YDB github reposhttps://code.mastervirt.ru/ydb/atom?h=oidc-1.2.32024-09-05T17:17:10ZFixNamespaceComments in /util2024-09-05T17:17:10Zdmasloffdmasloff@yandex-team.com2024-09-05T17:05:47Zurn:sha1:74184a40c15dc0649a769d9754d0ce7efb44db04
FixNamespaceComments in /util
bb9152570d7c258798644ead5a59f604de05ef3b
Set SpacesInLineCommentPrefix to 1 in /util2024-08-17T20:43:45Zdmasloffdmasloff@yandex-team.com2024-08-17T20:33:42Zurn:sha1:69340f4614e853b9319df4b454ab7497711ee3cd
Set SpacesInLineCommentPrefix to 1 in /util
3853f9ec5143722c1bebd8dc0ffc9b61a6c17657
[util] fix fstat for archive directories on windows2022-02-17T19:22:02Zkikhtkikht@yandex-team.ru2022-02-17T19:22:02Zurn:sha1:a4e5577781d9f1162779286558a90252430f6200
Currently TFileStat has a bunch of problems on Windows:
1. Mode computation ORs different types, but file attributes it checks are not mutually exclusive. E.g. it is possible for directory to have both `FILE_ATTRIBUTE_DIRECTORY` and `FILE_ATTRIBUTE_ARCHIVE`, but it will currently lead to invalid `_S_IFDIR | _S_IFREG` mode.
2. Any file with `FILE_ATTRIBUTE_REPARSE_POINT` flag is considered to be symlink. But there are many other types of reparse points even user-defined ones. For more info see https://docs.microsoft.com/en-us/windows/win32/fileio/reparse-point-tags
To fix all this we do the following:
1. Add `ReparseTag` field to `TSystemFStat` and fill it for reparse points in `GetStatByHandle`.
2. Refactor `GetWinFileType` out of `GetFileMode` to ensure that we always select only single `S_IFMT` value.
3. Pass reparse tag value into `GetWinFileType` and select `S_IFLNK` only for `IO_REPARSE_TAG_SYMLINK` and `IO_REPARSE_TAG_MOUNT_POINT` tags. The latter one is a bit strange, but this behaviour is aligned with current implementation of `WinReadLink`.
4. Factor `ReadReparsePoint` out of `WinReadLink`. This function uses `DeviceIoControl` to read reparse point data into structures copied from WDK.
5. Add `WinReadReparseTag` that uses `ReadReparsePoint` to extract reparse point tag. We use this approach instead of MSDN-recommended `FindFirstFile` because latter requires file path, but we have file handle at this point. AFAIK golang and python use similar approach for this.
6. Add test for archived directory case.
7. Make symlink nofollow tests run only when symlink creation is possible for current user.
Discovered in https://st.yandex-team.ru/ARC-3931
ref:4f6735817b9f85f3351a1021a56dd7eb4606bd65
Restoring authorship annotation for <muzykantov@yandex-team.ru>. Commit 2 of 2.2022-02-10T13:51:51Zmuzykantovmuzykantov@yandex-team.ru2022-02-10T13:51:51Zurn:sha1:fffc5498228bac1ad41ed40b9b7f5cb453796ba8Restoring authorship annotation for <muzykantov@yandex-team.ru>. Commit 1 of 2.2022-02-10T13:51:51Zmuzykantovmuzykantov@yandex-team.ru2022-02-10T13:51:51Zurn:sha1:8057fea3b8c36263516f0a7e1a01fdf7380764a4Restoring authorship annotation for Vasily Gerasimov <UgnineSirdis@gmail.com>. Commit 2 of 2.2022-02-10T13:49:10ZVasily GerasimovUgnineSirdis@gmail.com2022-02-10T13:49:10Zurn:sha1:1eb755fbca92172a6aec2f57371b2b3a19dfab43Restoring authorship annotation for Vasily Gerasimov <UgnineSirdis@gmail.com>. Commit 1 of 2.2022-02-10T13:49:09ZVasily GerasimovUgnineSirdis@gmail.com2022-02-10T13:49:09Zurn:sha1:6cdc8f140213c595e4ad38bc3d97fcef1146b8c3Restoring authorship annotation for <xpahos@yandex-team.ru>. Commit 2 of 2.2022-02-10T13:47:21Zxpahosxpahos@yandex-team.ru2022-02-10T13:47:21Zurn:sha1:da8fe75e5a837ef6a6e8a21f96dcee631e8b5a1eRestoring authorship annotation for <xpahos@yandex-team.ru>. Commit 1 of 2.2022-02-10T13:47:21Zxpahosxpahos@yandex-team.ru2022-02-10T13:47:21Zurn:sha1:52faf709473af8421da1e2ea84ae1879b16665b8Restoring authorship annotation for <yazevnul@yandex-team.ru>. Commit 2 of 2.2022-02-10T13:46:48Zyazevnulyazevnul@yandex-team.ru2022-02-10T13:46:48Zurn:sha1:9abfb1a53b7f7b791444d1378e645d8fad9b06ed