ydb/util/generic/strbuf.h, branch CLI_2.21.0Mirror of YDB github reposhttps://code.mastervirt.ru/ydb/atom?h=CLI_2.21.02025-03-11T17:34:27Zcheck lifetimes of TStringBuf constructed from TString without taking into account copy-on-write semantics2025-03-11T17:34:27Zswarmerswarmer@yandex-team.com2025-03-11T17:17:27Zurn:sha1:1d27939449612e7fc287df4599bc3f1fc5132ea6
`TString` is a copy-on-write type, which means that in some cases the valid lifetime of its data might extend beyond the lifetime of an individual `TString` (if it was copied).
However, there are practically no cases where this behaviour is appropriate, and leaving around an "owning" `TString` is undesirable.
Due to this behaviour we have previously refrained from enabling `[[clang::lifetimebound]]` for `TStringBuf` constructors, because some cases of view construction from a temporary `TString` were in fact valid.
This commit enables the check, as all existing related bugs in Arcadia have been fixed. Please see the related ticket and the announcement on Этушка (link will be in the post-commit comments) for more information.
commit_hash:b2b6831ac3106a4e76064b85ec2d748b415ed67c
Add assertions for range bounds validity2024-12-18T20:11:30Zakhropovakhropov@yandex-team.com2024-12-18T19:54:51Zurn:sha1:3a12c740b711f812b47062086b390345479f113c
commit_hash:4417c6200b3fc4e3e6e61648412d263366935fdf
Remove std::nullptr_t ctor for TString2024-12-09T10:55:35Zdgoleardgolear@yandex-team.com2024-12-09T10:34:13Zurn:sha1:d4510c40056498c21c4185bc678c4eed3ab89cea
commit_hash:6b02e6cb83bde366477f7d53b6cd6c00bffdb4d6
Part of PR. Style2024-11-20T10:14:09Znae202nae202@yandex-team.com2024-11-20T09:52:01Zurn:sha1:0b9d91e900b52bccd6eabd033acbb57c4ee173fc
Часть большого ПР REVIEW:7264088
commit_hash:0f5b03fbbed0ac30f734943309e3ef5cd4d7a30e
Set SpacesInLineCommentPrefix to 1 in /util2024-08-17T20:43:45Zdmasloffdmasloff@yandex-team.com2024-08-17T20:33:42Zurn:sha1:69340f4614e853b9319df4b454ab7497711ee3cd
Set SpacesInLineCommentPrefix to 1 in /util
3853f9ec5143722c1bebd8dc0ffc9b61a6c17657
check the lifetime bound of the TStringBuf, constructed from a substring of an another TStringBuf view2024-08-06T21:51:52Zswarmerswarmer@yandex-team.com2024-08-06T21:20:28Zurn:sha1:0e66090a90e6a55094d0f535599682b4adc04046
834bc8b5ef002eb217450def12b8887b071f3d5f
check the lifetime bound of the TStringBuf, constructed from a TStringBuf with different char-traits2024-08-06T21:47:06Zswarmerswarmer@yandex-team.com2024-08-06T21:20:13Zurn:sha1:0d7c47ec48cc2d7664630b9cc19d2fddc03ec0e3
8b52c36ebe25af42f8b0dae4d83fc067760600ba
check lifetime bounds of a TStringBuf constructed from pointers2024-07-27T11:09:40Zswarmerswarmer@yandex-team.com2024-07-27T10:59:12Zurn:sha1:d0de29447f964f405d9fc3f37618cf3796724c61
a64e291c4e9927286cc8f84fb9bb6b52d0da1345
check the lifetime bounds of a TStringBuf constructed from a TString, if TString is a std::string2024-07-24T19:51:20Zswarmerswarmer@yandex-team.com2024-07-24T19:39:30Zurn:sha1:81c8d5e42918da4bd9dbdd7b45a8b2471c8d9c84
04931f9cabff5a8b2a55ba25df5e3b546be4b745
check lifetime bounds of TStringBuf constructed from std::string2024-07-23T21:53:49Zswarmerswarmer@yandex-team.com2024-07-23T21:41:03Zurn:sha1:526d5a422b6ab6b2383b56eca9d1b84462ee2050
b8ba3acb34e82c520e14aad6e491130963fcee55