ydb/library/cpp/tld, branch docs-quickstart-add-mkdirMirror of YDB github reposhttps://code.mastervirt.ru/ydb/atom?h=docs-quickstart-add-mkdir2023-06-28T14:27:42Zfix gen_tld.py on non-unicode locale encodings2023-06-28T14:27:42ZNikita Kozlovskiynikitka@gmail.com2023-06-28T14:27:42Zurn:sha1:61de4a67fa045e1281fb392df8cbfbcd890bc104
fix gen_tld.py on non-unicode locale encodings
In python versions prior to 3.7, as well as when using non-unicode locale encodings, the `gen_tld.py` script fails:
```
ydb/ydb/library/cpp/tld % git rev-parse head
97b1a695d3be4edc08550d3ae7d200f6d9f3d42e
ydb/ydb/library/cpp/tld % LC_CTYPE=C ~/.pyenv/versions/3.6.15/bin/python gen_tld.py tlds-alpha-by-domain.txt|md5
Traceback (most recent call last):
File "gen_tld.py", line 57, in <module>
main()
File "gen_tld.py", line 39, in main
sys.stdout.write('%s*/\n' % str.rstrip())
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)
```
This pull request fixes this behevaiour by explicit set output encoding to utf-8.
To ensure that I do not break anything, I checked the MD5 hash of the generated file before and after making my changes:
```
ydb/ydb/library/cpp/tld % git rev-parse head
97b1a695d3be4edc08550d3ae7d200f6d9f3d42e
ydb/ydb/library/cpp/tld % python3 gen_tld.py tlds-alpha-by-domain.txt|md5
564242d355d842db790977df3642a405
```
After
```
ydb/ydb/library/cpp/tld % git rev-parse head
1096dd7f034c573aabdf3bac2dc4b181a6688c71
ydb/ydb/library/cpp/tld % python3 gen_tld.py tlds-alpha-by-domain.txt|md5
564242d355d842db790977df3642a405
ydb/ydb/library/cpp/tld % LC_CTYPE=C ~/.pyenv/versions/3.6.15/bin/python gen_tld.py tlds-alpha-by-domain.txt|md5
564242d355d842db790977df3642a405
```
Pull Request resolved: #279add ymake export to ydb2023-06-13T08:05:01Zalexv-smirnovalex@ydb.tech2023-06-13T08:05:01Zurn:sha1:bf0f13dd39ee3e65092ba3572bb5b1fcd125dcd0External build system generator release 292023-04-19T11:10:48Zrobot-ya-builderrobot-ya-builder@yandex-team.com2023-04-19T11:10:48Zurn:sha1:887be65957040bac40fa22a2af242de88920eba7
Update tools: yexportRevert ymake build from ydb oss export2023-03-28T19:25:04Zalexv-smirnovalex@ydb.tech2023-03-28T19:25:04Zurn:sha1:b8a17f9b1c166d2e9a26b99348a4c29d972caf55External build system generator release 212023-03-17T16:38:27Zrobot-ya-builderrobot-ya-builder@yandex-team.com2023-03-17T16:38:27Zurn:sha1:26147c4e01ae75f397d4dd999da238bf2c61c851
Update tools: yexportadd library/cpp/actors, ymake build to ydb oss export2023-03-15T16:59:12Zalexv-smirnovalex@ydb.tech2023-03-15T16:59:12Zurn:sha1:056bb284ccf8dd6793ec3a54ffa36c4fb2b9ad11Intermediate changes2023-03-09T09:42:44Zrobot-pigletrobot-piglet@yandex-team.com2023-03-09T09:42:44Zurn:sha1:6324d075a5e80b6943b5de6b465b775050fe83dfIntermediate changes2023-03-07T09:53:35Zrobot-pigletrobot-piglet@yandex-team.com2023-03-07T09:53:35Zurn:sha1:33ed6077e694c2f1286c01ebe1be30b189850e77External build system generator release 172023-03-06T13:56:18Zrobot-ya-builderrobot-ya-builder@yandex-team.com2023-03-06T13:56:18Zurn:sha1:cbc0c479c131a1e63ca86fe98b031e1bcac725d8
Update tools: yexportIntermediate changes2023-02-07T18:14:00Zrobot-pigletrobot-piglet@yandex-team.com2023-02-07T18:14:00Zurn:sha1:9f448c9c675e670d53bba7a8d74a995b2d9a3606