ffmpeg: rewrite setting the stream disposition

Currently, the code doing this is spread over several places and may
behave in unexpected ways. E.g. automatic 'default' marking is only done
for streams fed by complex filtergraphs. It is also applied in the order
in which the output streams are initialized, which is effectively
random.

Move processing the dispositions at the end of open_output_file(), when
we already have all the necessary information.

Apply the automatic default marking only if no explicit -disposition
options were supplied by the user, and apply it to the first stream of
each type (excluding attached pics) when there is more than one stream
of that type and no default markings were copied from the input streams.

Explicitly document the new behavior.

Changes the results of some tests, where the output file gets a default
disposition, while it previously did not.

1 files changed, 31 insertions, 31 deletions

diff --git a/tests/ref/fate/ffprobe_flat b/tests/ref/fate/ffprobe_flat
index 4b0b4b3881..e77dec6b84 100644
--- a/tests/ref/fate/ffprobe_flat
+++ b/tests/ref/fate/ffprobe_flat
@@ -7,7 +7,7 @@ packets_and_frames.packet.0.dts_time="0.000000"
 packets_and_frames.packet.0.duration=1024
 packets_and_frames.packet.0.duration_time="0.023220"
 packets_and_frames.packet.0.size="2048"
-packets_and_frames.packet.0.pos="647"
+packets_and_frames.packet.0.pos="669"
 packets_and_frames.packet.0.flags="K_"
 packets_and_frames.frame.0.media_type="audio"
 packets_and_frames.frame.0.stream_index=0
@@ -20,7 +20,7 @@ packets_and_frames.frame.0.best_effort_timestamp=0
 packets_and_frames.frame.0.best_effort_timestamp_time="0.000000"
 packets_and_frames.frame.0.pkt_duration=1024
 packets_and_frames.frame.0.pkt_duration_time="0.023220"
-packets_and_frames.frame.0.pkt_pos="647"
+packets_and_frames.frame.0.pkt_pos="669"
 packets_and_frames.frame.0.pkt_size="2048"
 packets_and_frames.frame.0.sample_fmt="s16"
 packets_and_frames.frame.0.nb_samples=1024
@@ -35,7 +35,7 @@ packets_and_frames.packet.1.dts_time="0.000000"
 packets_and_frames.packet.1.duration=2048
 packets_and_frames.packet.1.duration_time="0.040000"
 packets_and_frames.packet.1.size="230400"
-packets_and_frames.packet.1.pos="2722"
+packets_and_frames.packet.1.pos="2744"
 packets_and_frames.packet.1.flags="K_"
 packets_and_frames.frame.1.media_type="video"
 packets_and_frames.frame.1.stream_index=1
@@ -48,7 +48,7 @@ packets_and_frames.frame.1.best_effort_timestamp=0
 packets_and_frames.frame.1.best_effort_timestamp_time="0.000000"
 packets_and_frames.frame.1.pkt_duration=2048
 packets_and_frames.frame.1.pkt_duration_time="0.040000"
-packets_and_frames.frame.1.pkt_pos="2722"
+packets_and_frames.frame.1.pkt_pos="2744"
 packets_and_frames.frame.1.pkt_size="230400"
 packets_and_frames.frame.1.width=320
 packets_and_frames.frame.1.height=240
@@ -74,7 +74,7 @@ packets_and_frames.packet.2.dts_time="0.000000"
 packets_and_frames.packet.2.duration=2048
 packets_and_frames.packet.2.duration_time="0.040000"
 packets_and_frames.packet.2.size="30000"
-packets_and_frames.packet.2.pos="233143"
+packets_and_frames.packet.2.pos="233165"
 packets_and_frames.packet.2.flags="K_"
 packets_and_frames.frame.2.media_type="video"
 packets_and_frames.frame.2.stream_index=2
@@ -87,7 +87,7 @@ packets_and_frames.frame.2.best_effort_timestamp=0
 packets_and_frames.frame.2.best_effort_timestamp_time="0.000000"
 packets_and_frames.frame.2.pkt_duration=2048
 packets_and_frames.frame.2.pkt_duration_time="0.040000"
-packets_and_frames.frame.2.pkt_pos="233143"
+packets_and_frames.frame.2.pkt_pos="233165"
 packets_and_frames.frame.2.pkt_size="30000"
 packets_and_frames.frame.2.width=100
 packets_and_frames.frame.2.height=100
@@ -113,7 +113,7 @@ packets_and_frames.packet.3.dts_time="0.023220"
 packets_and_frames.packet.3.duration=1024
 packets_and_frames.packet.3.duration_time="0.023220"
 packets_and_frames.packet.3.size="2048"
-packets_and_frames.packet.3.pos="263148"
+packets_and_frames.packet.3.pos="263170"
 packets_and_frames.packet.3.flags="K_"
 packets_and_frames.frame.3.media_type="audio"
 packets_and_frames.frame.3.stream_index=0
@@ -126,7 +126,7 @@ packets_and_frames.frame.3.best_effort_timestamp=1024
 packets_and_frames.frame.3.best_effort_timestamp_time="0.023220"
 packets_and_frames.frame.3.pkt_duration=1024
 packets_and_frames.frame.3.pkt_duration_time="0.023220"
-packets_and_frames.frame.3.pkt_pos="263148"
+packets_and_frames.frame.3.pkt_pos="263170"
 packets_and_frames.frame.3.pkt_size="2048"
 packets_and_frames.frame.3.sample_fmt="s16"
 packets_and_frames.frame.3.nb_samples=1024
@@ -141,7 +141,7 @@ packets_and_frames.packet.4.dts_time="0.040000"
 packets_and_frames.packet.4.duration=2048
 packets_and_frames.packet.4.duration_time="0.040000"
 packets_and_frames.packet.4.size="230400"
-packets_and_frames.packet.4.pos="265226"
+packets_and_frames.packet.4.pos="265248"
 packets_and_frames.packet.4.flags="K_"
 packets_and_frames.frame.4.media_type="video"
 packets_and_frames.frame.4.stream_index=1
@@ -154,7 +154,7 @@ packets_and_frames.frame.4.best_effort_timestamp=2048
 packets_and_frames.frame.4.best_effort_timestamp_time="0.040000"
 packets_and_frames.frame.4.pkt_duration=2048
 packets_and_frames.frame.4.pkt_duration_time="0.040000"
-packets_and_frames.frame.4.pkt_pos="265226"
+packets_and_frames.frame.4.pkt_pos="265248"
 packets_and_frames.frame.4.pkt_size="230400"
 packets_and_frames.frame.4.width=320
 packets_and_frames.frame.4.height=240
@@ -180,7 +180,7 @@ packets_and_frames.packet.5.dts_time="0.040000"
 packets_and_frames.packet.5.duration=2048
 packets_and_frames.packet.5.duration_time="0.040000"
 packets_and_frames.packet.5.size="30000"
-packets_and_frames.packet.5.pos="495650"
+packets_and_frames.packet.5.pos="495672"
 packets_and_frames.packet.5.flags="K_"
 packets_and_frames.frame.5.media_type="video"
 packets_and_frames.frame.5.stream_index=2
@@ -193,7 +193,7 @@ packets_and_frames.frame.5.best_effort_timestamp=2048
 packets_and_frames.frame.5.best_effort_timestamp_time="0.040000"
 packets_and_frames.frame.5.pkt_duration=2048
 packets_and_frames.frame.5.pkt_duration_time="0.040000"
-packets_and_frames.frame.5.pkt_pos="495650"
+packets_and_frames.frame.5.pkt_pos="495672"
 packets_and_frames.frame.5.pkt_size="30000"
 packets_and_frames.frame.5.width=100
 packets_and_frames.frame.5.height=100
@@ -219,7 +219,7 @@ packets_and_frames.packet.6.dts_time="0.046440"
 packets_and_frames.packet.6.duration=1024
 packets_and_frames.packet.6.duration_time="0.023220"
 packets_and_frames.packet.6.size="2048"
-packets_and_frames.packet.6.pos="525655"
+packets_and_frames.packet.6.pos="525677"
 packets_and_frames.packet.6.flags="K_"
 packets_and_frames.frame.6.media_type="audio"
 packets_and_frames.frame.6.stream_index=0
@@ -232,7 +232,7 @@ packets_and_frames.frame.6.best_effort_timestamp=2048
 packets_and_frames.frame.6.best_effort_timestamp_time="0.046440"
 packets_and_frames.frame.6.pkt_duration=1024
 packets_and_frames.frame.6.pkt_duration_time="0.023220"
-packets_and_frames.frame.6.pkt_pos="525655"
+packets_and_frames.frame.6.pkt_pos="525677"
 packets_and_frames.frame.6.pkt_size="2048"
 packets_and_frames.frame.6.sample_fmt="s16"
 packets_and_frames.frame.6.nb_samples=1024
@@ -247,7 +247,7 @@ packets_and_frames.packet.7.dts_time="0.069660"
 packets_and_frames.packet.7.duration=1024
 packets_and_frames.packet.7.duration_time="0.023220"
 packets_and_frames.packet.7.size="2048"
-packets_and_frames.packet.7.pos="527726"
+packets_and_frames.packet.7.pos="527748"
 packets_and_frames.packet.7.flags="K_"
 packets_and_frames.frame.7.media_type="audio"
 packets_and_frames.frame.7.stream_index=0
@@ -260,7 +260,7 @@ packets_and_frames.frame.7.best_effort_timestamp=3072
 packets_and_frames.frame.7.best_effort_timestamp_time="0.069660"
 packets_and_frames.frame.7.pkt_duration=1024
 packets_and_frames.frame.7.pkt_duration_time="0.023220"
-packets_and_frames.frame.7.pkt_pos="527726"
+packets_and_frames.frame.7.pkt_pos="527748"
 packets_and_frames.frame.7.pkt_size="2048"
 packets_and_frames.frame.7.sample_fmt="s16"
 packets_and_frames.frame.7.nb_samples=1024
@@ -275,7 +275,7 @@ packets_and_frames.packet.8.dts_time="0.080000"
 packets_and_frames.packet.8.duration=2048
 packets_and_frames.packet.8.duration_time="0.040000"
 packets_and_frames.packet.8.size="230400"
-packets_and_frames.packet.8.pos="529804"
+packets_and_frames.packet.8.pos="529826"
 packets_and_frames.packet.8.flags="K_"
 packets_and_frames.frame.8.media_type="video"
 packets_and_frames.frame.8.stream_index=1
@@ -288,7 +288,7 @@ packets_and_frames.frame.8.best_effort_timestamp=4096
 packets_and_frames.frame.8.best_effort_timestamp_time="0.080000"
 packets_and_frames.frame.8.pkt_duration=2048
 packets_and_frames.frame.8.pkt_duration_time="0.040000"
-packets_and_frames.frame.8.pkt_pos="529804"
+packets_and_frames.frame.8.pkt_pos="529826"
 packets_and_frames.frame.8.pkt_size="230400"
 packets_and_frames.frame.8.width=320
 packets_and_frames.frame.8.height=240
@@ -314,7 +314,7 @@ packets_and_frames.packet.9.dts_time="0.080000"
 packets_and_frames.packet.9.duration=2048
 packets_and_frames.packet.9.duration_time="0.040000"
 packets_and_frames.packet.9.size="30000"
-packets_and_frames.packet.9.pos="760228"
+packets_and_frames.packet.9.pos="760250"
 packets_and_frames.packet.9.flags="K_"
 packets_and_frames.frame.9.media_type="video"
 packets_and_frames.frame.9.stream_index=2
@@ -327,7 +327,7 @@ packets_and_frames.frame.9.best_effort_timestamp=4096
 packets_and_frames.frame.9.best_effort_timestamp_time="0.080000"
 packets_and_frames.frame.9.pkt_duration=2048
 packets_and_frames.frame.9.pkt_duration_time="0.040000"
-packets_and_frames.frame.9.pkt_pos="760228"
+packets_and_frames.frame.9.pkt_pos="760250"
 packets_and_frames.frame.9.pkt_size="30000"
 packets_and_frames.frame.9.width=100
 packets_and_frames.frame.9.height=100
@@ -353,7 +353,7 @@ packets_and_frames.packet.10.dts_time="0.092880"
 packets_and_frames.packet.10.duration=1024
 packets_and_frames.packet.10.duration_time="0.023220"
 packets_and_frames.packet.10.size="2048"
-packets_and_frames.packet.10.pos="790233"
+packets_and_frames.packet.10.pos="790255"
 packets_and_frames.packet.10.flags="K_"
 packets_and_frames.frame.10.media_type="audio"
 packets_and_frames.frame.10.stream_index=0
@@ -366,7 +366,7 @@ packets_and_frames.frame.10.best_effort_timestamp=4096
 packets_and_frames.frame.10.best_effort_timestamp_time="0.092880"
 packets_and_frames.frame.10.pkt_duration=1024
 packets_and_frames.frame.10.pkt_duration_time="0.023220"
-packets_and_frames.frame.10.pkt_pos="790233"
+packets_and_frames.frame.10.pkt_pos="790255"
 packets_and_frames.frame.10.pkt_size="2048"
 packets_and_frames.frame.10.sample_fmt="s16"
 packets_and_frames.frame.10.nb_samples=1024
@@ -381,7 +381,7 @@ packets_and_frames.packet.11.dts_time="0.116100"
 packets_and_frames.packet.11.duration=393
 packets_and_frames.packet.11.duration_time="0.008912"
 packets_and_frames.packet.11.size="786"
-packets_and_frames.packet.11.pos="792304"
+packets_and_frames.packet.11.pos="792326"
 packets_and_frames.packet.11.flags="K_"
 packets_and_frames.frame.11.media_type="audio"
 packets_and_frames.frame.11.stream_index=0
@@ -394,7 +394,7 @@ packets_and_frames.frame.11.best_effort_timestamp=5120
 packets_and_frames.frame.11.best_effort_timestamp_time="0.116100"
 packets_and_frames.frame.11.pkt_duration=393
 packets_and_frames.frame.11.pkt_duration_time="0.008912"
-packets_and_frames.frame.11.pkt_pos="792304"
+packets_and_frames.frame.11.pkt_pos="792326"
 packets_and_frames.frame.11.pkt_size="786"
 packets_and_frames.frame.11.sample_fmt="s16"
 packets_and_frames.frame.11.nb_samples=393
@@ -409,7 +409,7 @@ packets_and_frames.packet.12.dts_time="0.120000"
 packets_and_frames.packet.12.duration=2048
 packets_and_frames.packet.12.duration_time="0.040000"
 packets_and_frames.packet.12.size="230400"
-packets_and_frames.packet.12.pos="793120"
+packets_and_frames.packet.12.pos="793142"
 packets_and_frames.packet.12.flags="K_"
 packets_and_frames.frame.12.media_type="video"
 packets_and_frames.frame.12.stream_index=1
@@ -422,7 +422,7 @@ packets_and_frames.frame.12.best_effort_timestamp=6144
 packets_and_frames.frame.12.best_effort_timestamp_time="0.120000"
 packets_and_frames.frame.12.pkt_duration=2048
 packets_and_frames.frame.12.pkt_duration_time="0.040000"
-packets_and_frames.frame.12.pkt_pos="793120"
+packets_and_frames.frame.12.pkt_pos="793142"
 packets_and_frames.frame.12.pkt_size="230400"
 packets_and_frames.frame.12.width=320
 packets_and_frames.frame.12.height=240
@@ -448,7 +448,7 @@ packets_and_frames.packet.13.dts_time="0.120000"
 packets_and_frames.packet.13.duration=2048
 packets_and_frames.packet.13.duration_time="0.040000"
 packets_and_frames.packet.13.size="30000"
-packets_and_frames.packet.13.pos="1023544"
+packets_and_frames.packet.13.pos="1023566"
 packets_and_frames.packet.13.flags="K_"
 packets_and_frames.frame.13.media_type="video"
 packets_and_frames.frame.13.stream_index=2
@@ -461,7 +461,7 @@ packets_and_frames.frame.13.best_effort_timestamp=6144
 packets_and_frames.frame.13.best_effort_timestamp_time="0.120000"
 packets_and_frames.frame.13.pkt_duration=2048
 packets_and_frames.frame.13.pkt_duration_time="0.040000"
-packets_and_frames.frame.13.pkt_pos="1023544"
+packets_and_frames.frame.13.pkt_pos="1023566"
 packets_and_frames.frame.13.pkt_size="30000"
 packets_and_frames.frame.13.width=100
 packets_and_frames.frame.13.height=100
@@ -560,7 +560,7 @@ streams.stream.1.bits_per_raw_sample="N/A"
 streams.stream.1.nb_frames="N/A"
 streams.stream.1.nb_read_frames="4"
 streams.stream.1.nb_read_packets="4"
-streams.stream.1.disposition.default=0
+streams.stream.1.disposition.default=1
 streams.stream.1.disposition.dub=0
 streams.stream.1.disposition.original=0
 streams.stream.1.disposition.comment=0
@@ -642,8 +642,8 @@ format.nb_programs=0
 format.format_name="nut"
 format.start_time="0.000000"
 format.duration="0.120000"
-format.size="1053624"
-format.bit_rate="70241600"
+format.size="1053646"
+format.bit_rate="70243066"
 format.probe_score=100
 format.tags.title="ffprobe test file"
 format.tags.comment="'A comment with CSV, XML & JSON special chars': <tag value=\"x\">"