aboutsummaryrefslogtreecommitdiffstats
path: root/libavformat/riffdec.c
diff options
context:
space:
mode:
authorMarios Titas <redneb@gmx.com>2016-04-02 21:11:44 +0300
committerMichael Niedermayer <michael@niedermayer.cc>2016-04-03 01:50:08 +0200
commitc1f9734f977f59bc0034096afbe8e43e40d93a5d (patch)
tree04e9d365dd1d92a6c52565698a227b5b2d2d900f /libavformat/riffdec.c
parentce87711df563a9d2d0537a062b86bb91b15ea1a0 (diff)
downloadffmpeg-c1f9734f977f59bc0034096afbe8e43e40d93a5d.tar.gz
avfilter/src_movie: fix how we check for overflows with seek_point
Currently, if the movie source filter is used and a seek_point is specified on a file that has a negative start time, ffmpeg will fail. An easy way to reproduce this is as follows: $ ffmpeg -vsync passthrough -filter_complex 'color=d=10,setpts=PTS-1/TB' test.mp4 $ ffmpeg -filter_complex 'movie=filename=test.mp4:seek_point=2' -f null - The problem is caused by checking for int64_t overflow the wrong way. In general, to check whether a + b overflows, it is not enough to do: a > INT64_MAX - b because b might be negative; the correct way is: b > 0 && > a > INT64_MAX - b Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavformat/riffdec.c')
0 files changed, 0 insertions, 0 deletions