aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2021-08-29 22:44:36 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@outlook.com>2022-09-19 17:05:33 +0200
commit129cbbd7be16fc0c396cfbb291794174735dbaf7 (patch)
treee900e0af8a56aca7117e05e5569297977a4ca2fa /libavcodec
parent017d976629ea272965ea67201543c8b5538cbf09 (diff)
downloadffmpeg-129cbbd7be16fc0c396cfbb291794174735dbaf7.tar.gz
avcodec/aptxenc: Process data in complete blocks of four samples only
Do this by setting AVCodecInternal.pad_samples. This prevents reading into the frame's padding and writing into the packet's padding. This actually happened in our FATE tests (where the number of samples is 2 mod 4), which therefore needed to be updated. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/aptxenc.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/libavcodec/aptxenc.c b/libavcodec/aptxenc.c
index 434a9abf0f..114e286fe2 100644
--- a/libavcodec/aptxenc.c
+++ b/libavcodec/aptxenc.c
@@ -27,6 +27,7 @@
#include "audio_frame_queue.h"
#include "codec_internal.h"
#include "encode.h"
+#include "internal.h"
typedef struct AptXEncContext {
AptXContext common;
@@ -259,6 +260,7 @@ static av_cold int aptx_encode_init(AVCodecContext *avctx)
if (!avctx->frame_size || avctx->frame_size % 4)
avctx->frame_size = 1024;
+ avctx->internal->pad_samples = 4;
return ff_aptx_init(avctx);
}
@@ -269,7 +271,7 @@ const FFCodec ff_aptx_encoder = {
CODEC_LONG_NAME("aptX (Audio Processing Technology for Bluetooth)"),
.p.type = AVMEDIA_TYPE_AUDIO,
.p.id = AV_CODEC_ID_APTX,
- .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SMALL_LAST_FRAME,
+ .p.capabilities = AV_CODEC_CAP_DR1,
.priv_data_size = sizeof(AptXEncContext),
.init = aptx_encode_init,
FF_CODEC_ENCODE_CB(aptx_encode_frame),
@@ -290,7 +292,7 @@ const FFCodec ff_aptx_hd_encoder = {
CODEC_LONG_NAME("aptX HD (Audio Processing Technology for Bluetooth)"),
.p.type = AVMEDIA_TYPE_AUDIO,
.p.id = AV_CODEC_ID_APTX_HD,
- .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SMALL_LAST_FRAME,
+ .p.capabilities = AV_CODEC_CAP_DR1,
.priv_data_size = sizeof(AptXEncContext),
.init = aptx_encode_init,
FF_CODEC_ENCODE_CB(aptx_encode_frame),