diff options
author | Justin Ruggles <justin.ruggles@gmail.com> | 2011-10-28 00:52:36 -0400 |
---|---|---|
committer | Justin Ruggles <justin.ruggles@gmail.com> | 2011-11-02 14:41:16 -0400 |
commit | b03761b1309293bbf30edef767503875277b01cf (patch) | |
tree | f9ef4d293b437752169e35bb4ca975a48fdb2e3b /libavcodec | |
parent | bac2597a32b774db9b72163d1476673b57ea0187 (diff) | |
download | ffmpeg-b03761b1309293bbf30edef767503875277b01cf.tar.gz |
libgsmdec: check output buffer size before decoding
Diffstat (limited to 'libavcodec')
-rw-r--r-- | libavcodec/libgsm.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/libavcodec/libgsm.c b/libavcodec/libgsm.c index 951e736098..6362f51ecb 100644 --- a/libavcodec/libgsm.c +++ b/libavcodec/libgsm.c @@ -168,18 +168,25 @@ static int libgsm_decode_frame(AVCodecContext *avctx, AVPacket *avpkt) { uint8_t *buf = avpkt->data; int buf_size = avpkt->size; + int out_size = avctx->frame_size * av_get_bytes_per_sample(avctx->sample_fmt); + + if (*data_size < out_size) { + av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n"); + return AVERROR(EINVAL); + } + *data_size = 0; /* In case of error */ if(buf_size < avctx->block_align) return -1; switch(avctx->codec_id) { case CODEC_ID_GSM: if(gsm_decode(avctx->priv_data,buf,data)) return -1; - *data_size = GSM_FRAME_SIZE*sizeof(int16_t); break; case CODEC_ID_GSM_MS: if(gsm_decode(avctx->priv_data,buf,data) || gsm_decode(avctx->priv_data,buf+33,((int16_t*)data)+GSM_FRAME_SIZE)) return -1; - *data_size = GSM_FRAME_SIZE*sizeof(int16_t)*2; } + + *data_size = out_size; return avctx->block_align; } |