diff options
| author | Diego Biurrun <diego@biurrun.de> | 2013-01-24 17:01:32 +0100 |
|---|---|---|
| committer | Diego Biurrun <diego@biurrun.de> | 2013-01-26 11:19:22 +0100 |
| commit | 033a86f9bb6fd59ca71d4951b8e2e27cdc1b29d9 (patch) | |
| tree | 8b8563e67a05ffd8855e69a7955d3dc005c71bf1 /libavcodec/x86 | |
| parent | 0e3afacd4d8fbe1c21e0bc16bd707809cd87380f (diff) | |
| download | ffmpeg-033a86f9bb6fd59ca71d4951b8e2e27cdc1b29d9.tar.gz | |
x86: h264qpel: Move stray comment to the right spot and clarify it
Diffstat (limited to 'libavcodec/x86')
| -rw-r--r-- | libavcodec/x86/dsputil_mmx.c | 2 | ||||
| -rw-r--r-- | libavcodec/x86/h264_qpel.c | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c index f9da04f6ea..f72500e4f0 100644 --- a/libavcodec/x86/dsputil_mmx.c +++ b/libavcodec/x86/dsputil_mmx.c @@ -2181,8 +2181,6 @@ static void dsputil_init_avx(DSPContext *c, AVCodecContext *avctx, int mm_flags) const int bit_depth = avctx->bits_per_raw_sample; if (bit_depth == 10) { - // AVX implies !cache64. - // TODO: Port cache(32|64) detection from x264. if (CONFIG_H264CHROMA) { c->put_h264_chroma_pixels_tab[0] = ff_put_h264_chroma_mc8_10_avx; c->avg_h264_chroma_pixels_tab[0] = ff_avg_h264_chroma_mc8_10_avx; diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c index 9157223c84..64af8fe17c 100644 --- a/libavcodec/x86/h264_qpel.c +++ b/libavcodec/x86/h264_qpel.c @@ -611,6 +611,10 @@ void ff_h264qpel_init_x86(H264QpelContext *c, int bit_depth) } if (EXTERNAL_AVX(mm_flags)) { + /* AVX implies 64 byte cache lines without the need to avoid unaligned + * memory accesses that cross the boundary between two cache lines. + * TODO: Port X264_CPU_CACHELINE_32/64 detection from x264 to avoid + * having to treat SSE2 functions with such properties as AVX. */ if (bit_depth == 10) { H264_QPEL_FUNCS_10(1, 0, sse2); H264_QPEL_FUNCS_10(2, 0, sse2); |