diff options
author | wm4 <nfxjfg@googlemail.com> | 2015-01-08 17:19:17 +0100 |
---|---|---|
committer | Michael Niedermayer <michaelni@gmx.at> | 2015-01-08 17:45:32 +0100 |
commit | 816577716bc6170bccfea3b9e865618b69a4b426 (patch) | |
tree | 418827185f06416c001e80801362814db55f4a27 /libavcodec/msvideo1.c | |
parent | 3fd3647fdc5b13348df299a70ada00d712ff84e4 (diff) | |
download | ffmpeg-816577716bc6170bccfea3b9e865618b69a4b426.tar.gz |
avcodec/dvdsubdec: fix accessing dangling pointers
dvdsub_decode() can call append_to_cached_buf() 2 times, the second time
with ctx->buf as argument. If the second append_to_cached_buf() reallocs
ctx->buf, the argument will be a pointer to the previous, freed block.
This can cause invalid reads at least with some fuzzed files - and
possibly with valid files.
Since packets can apparently not be larger than 64K (even if packets are
combined), just use a fixed size buffer. It will be allocated as part of
the DVDSubContext, and although some memory is "wasted", it's relatively
minimal by modern standards and should be acceptable.
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/msvideo1.c')
0 files changed, 0 insertions, 0 deletions