diff options
author | Ronald S. Bultje <rsbultje@gmail.com> | 2012-02-24 16:12:18 -0800 |
---|---|---|
committer | Reinhard Tartler <siretart@tauware.de> | 2012-04-01 18:33:26 +0200 |
commit | 6c12293f6c3c91d5fbbb1146ad0f77b887abed48 (patch) | |
tree | 5e72357fdc531304f1237f16561521846895efa6 /libavcodec/mpegaudiodecheader.h | |
parent | dd7b323d9a2f6ddc0e277403fdbd06226306f4a1 (diff) | |
download | ffmpeg-6c12293f6c3c91d5fbbb1146ad0f77b887abed48.tar.gz |
matroska: don't overwrite string values until read/alloc was succesful.
This prevents certain tags with a default value assigned to them (as per
the EBML syntax elements) from ever being assigned a NULL value. Other
parts of the code rely on these being non-NULL (i.e. they don't check for
NULL before e.g. using the string in strcmp() or similar), and thus in
effect this prevents crashes when reading of such specific tags fails,
either because of low memory or because of targeted file corruption.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
(cherry picked from commit cd40c31ee9ad2cca6f3635950b002fd46be07e98)
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Reinhard Tartler <siretart@tauware.de>
Diffstat (limited to 'libavcodec/mpegaudiodecheader.h')
0 files changed, 0 insertions, 0 deletions