diff options
author | Reimar Döffinger <Reimar.Doeffinger@gmx.de> | 2009-07-04 18:20:35 +0000 |
---|---|---|
committer | Reimar Döffinger <Reimar.Doeffinger@gmx.de> | 2009-07-04 18:20:35 +0000 |
commit | 643fd8a198ddb67225f5edd503f8f151d13635a3 (patch) | |
tree | d9e9cae67913c6c562d581673fe6b5ec235af9b1 /libavcodec/mjpegdec.c | |
parent | b27bf2a7b4fd57c36eccb11f5af794d4b940cfdc (diff) | |
download | ffmpeg-643fd8a198ddb67225f5edd503f8f151d13635a3.tar.gz |
Add a got_picture flag to MJpegDecodeContext which indicates if its picture
element is valid. Skip the code handling SOS and EOI if not, since it can not
work without a valid AVPicture.
This fixes a crash with mjpeg/smclockmjpeg.avi.1.0 from issue 1240 where the
decoder returned an invalid AVPicture.
Originally committed as revision 19342 to svn://svn.ffmpeg.org/ffmpeg/trunk
Diffstat (limited to 'libavcodec/mjpegdec.c')
-rw-r--r-- | libavcodec/mjpegdec.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 90b87f412b..b5f8281cc1 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -338,6 +338,7 @@ int ff_mjpeg_decode_sof(MJpegDecodeContext *s) } s->picture.pict_type= FF_I_TYPE; s->picture.key_frame= 1; + s->got_picture = 1; for(i=0; i<3; i++){ s->linesize[i]= s->picture.linesize[i] << s->interlaced; @@ -1249,6 +1250,7 @@ int ff_mjpeg_decode_frame(AVCodecContext *avctx, int start_code; AVFrame *picture = data; + s->got_picture = 0; // picture from previous image can not be reused buf_ptr = buf; buf_end = buf + buf_size; while (buf_ptr < buf_end) { @@ -1410,6 +1412,10 @@ int ff_mjpeg_decode_frame(AVCodecContext *avctx, if ((s->buggy_avid && !s->interlaced) || s->restart_interval) break; eoi_parser: + if (!s->got_picture) { + av_log(avctx, AV_LOG_WARNING, "Found EOI before any SOF, ignoring\n"); + break; + } { if (s->interlaced) { s->bottom_field ^= 1; @@ -1434,6 +1440,10 @@ eoi_parser: } break; case SOS: + if (!s->got_picture) { + av_log(avctx, AV_LOG_WARNING, "Can not process SOS before SOF, skipping\n"); + break; + } ff_mjpeg_decode_sos(s); /* buggy avid puts EOI every 10-20th frame */ /* if restart period is over process EOI */ |