aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/mips/aacdec_mips.h
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2019-04-20 00:03:15 +0200
committerPaul B Mahol <onemda@gmail.com>2019-07-12 14:56:27 +0200
commit8c6ee7626bcce7c270360f33b60dc7ef99939fc3 (patch)
tree42635652610b23204fd511f7815135b100151389 /libavcodec/mips/aacdec_mips.h
parent2601eef850f1ec37fdcc6f36c89eeb1d361de348 (diff)
downloadffmpeg-8c6ee7626bcce7c270360f33b60dc7ef99939fc3.tar.gz
lavf/webm_chunk: Fix NULL dereference
The earlier version of the webm_chunk muxer had several bugs: 1. If the first packet of an audio stream didn't have a PTS of zero, then no chunk will be started before a packet is delivered to the underlying Matroska/WebM muxer, i.e. the AVFormatContext used to write these packets had a NULL as AVIOContext for output. This is behind the crash in ticket #5752. 2. If an error happens during writing a packet, the underlyimg Matroska/WebM muxer context is freed. This leads to a use-after-free coupled with a double-free in webm_chunk_write_trailer (which supposes that the underlying AVFormatContext is still valid). 3. Even when no error occurs at all, webm_chunk_write_trailer is still buggy: After the underlying Matroska/WebM muxer has written its trailer, ending the chunk implicitly flushes it again which is illegal at this point. These bugs have been fixed. Fixes #5752. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Diffstat (limited to 'libavcodec/mips/aacdec_mips.h')
0 files changed, 0 insertions, 0 deletions