diff options
| author | Diego Biurrun <diego@biurrun.de> | 2008-10-29 06:48:59 +0000 |
|---|---|---|
| committer | Diego Biurrun <diego@biurrun.de> | 2008-10-29 06:48:59 +0000 |
| commit | 2cdba8bfc43b818ca8037421c9a136fa89327c66 (patch) | |
| tree | bbb84cb09f61d8e1abc72e4fb22e331bfc3040c1 /doc/general.texi | |
| parent | ba26cfab47e960cd3a4a106bcd7d45943bdc5961 (diff) | |
| download | ffmpeg-2cdba8bfc43b818ca8037421c9a136fa89327c66.tar.gz | |
Add 'make checkheaders' to developer guidelines and patch checklist.
Originally committed as revision 15741 to svn://svn.ffmpeg.org/ffmpeg/trunk
Diffstat (limited to 'doc/general.texi')
| -rw-r--r-- | doc/general.texi | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/general.texi b/doc/general.texi index 78372f6a0c..9a823d4d8c 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -951,6 +951,9 @@ should also be avoided if they don't make the code easier to understand. @item If you add a new file, give it a proper license header. Do not copy and paste it from a random place, use an existing file as template. +@item + If you add a new header or change an existing one, make sure it passes + @code{make checkheaders}. @end enumerate We think our rules are not too hard. If you have comments, contact us. @@ -1026,6 +1029,8 @@ do not attach several unrelated patches to the same mail. @item Do the regression tests pass with the patch applied? @item + Does @code{make checkheaders} pass with the patch applied? +@item Is the patch a unified diff? @item Is the patch against latest FFmpeg SVN? |