aboutsummaryrefslogtreecommitdiffstats
path: root/MAINTAINERS
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2019-11-29 20:44:09 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2019-12-01 17:17:04 +0100
commit35005a4af1ebe1ec1b5724121a03036705417fc7 (patch)
treef0449ad4dba25200fb93261ccf74e0b2e640c29e /MAINTAINERS
parent9cc88ed4b71cdb2ea95e584a9cc3651d1cb52427 (diff)
downloadffmpeg-35005a4af1ebe1ec1b5724121a03036705417fc7.tar.gz
avformat/flac_picture: Simplify checks
During parsing a flac picture metadata block, the mimetype is read as follows: Its 32b size field is read and checked for being in the range 1..63; afterwards, the actual mimetype-string is read into a buffer of size 64, where the length to read is the minimum of the length field and the size of the destination buffer -1. Then an assert guards that length is indeed < the size of the destination buffer before the string in the buffer is zero-terminated. The FFMIN as well as the assert are actually redundant, as it has been checked that the string (even after terminating) fits into the buffer. In order to make this clear, reword the check "len >= 64" to "len >= sizeof(mimetype)" and drop the FFMIN as well as the assert. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions