aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Xu (Hello71) <alex_y_xu@yahoo.ca>2021-11-25 14:36:46 -0500
committerMichael Niedermayer <michael@niedermayer.cc>2021-11-27 18:24:49 +0100
commit6fdd7fe0b89f5f76314bf06a7d28fb18d0196f84 (patch)
treef3226b0233c98e3ec53fa7a393b71117c9d0e067
parentcd0bdce71ac0b9871fa04d31756daa26fa7999af (diff)
downloadffmpeg-6fdd7fe0b89f5f76314bf06a7d28fb18d0196f84.tar.gz
avformat/img2dec: probe JFIF/Exif header
Due to reasons, mpv doesn't pass filename when probing. mpv also sets default probescore threshold to 26. Since the current jpeg_probe implementation returns 25 until EOI, it means that the whole image needs to be probed to succeed. Worse, the whole image is not passed at once; increasingly large buffers are tried before that. Adding it up together, if many demuxers are enabled, moderately large JPEG files (few MB) can take several seconds to open, despite taking less than 1 second to actually decode. Therefore, adjust the heuristic to be more optimistic if proper JFIF or Exif segments are found. While not strictly required, the vast majority of JPEG-ish files have one or the other or both. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/img2dec.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
index b535831e1c..a6084ceef0 100644
--- a/libavformat/img2dec.c
+++ b/libavformat/img2dec.c
@@ -749,7 +749,7 @@ static int j2k_probe(const AVProbeData *p)
static int jpeg_probe(const AVProbeData *p)
{
const uint8_t *b = p->buf;
- int i, state = SOI;
+ int i, state = SOI, got_header = 0;
if (AV_RB16(b) != 0xFFD8 ||
AV_RB32(b) == 0xFFD8FFF7)
@@ -789,7 +789,11 @@ static int jpeg_probe(const AVProbeData *p)
break;
case DQT:
case APP0:
+ if (AV_RL32(&b[i + 4]) == MKTAG('J','F','I','F'))
+ got_header = 1;
case APP1:
+ if (AV_RL32(&b[i + 4]) == MKTAG('E','x','i','f'))
+ got_header = 1;
case APP2:
case APP3:
case APP4:
@@ -817,7 +821,7 @@ static int jpeg_probe(const AVProbeData *p)
if (state == EOI)
return AVPROBE_SCORE_EXTENSION + 1;
if (state == SOS)
- return AVPROBE_SCORE_EXTENSION / 2;
+ return AVPROBE_SCORE_EXTENSION / 2 + got_header;
return AVPROBE_SCORE_EXTENSION / 8 + 1;
}