diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2015-08-27 04:08:42 +0200 |
|---|---|---|
| committer | Carl Eugen Hoyos <cehoyos@ag.or.at> | 2015-10-10 01:22:29 +0200 |
| commit | 30c644afebb991b61dec313cc2d6a01971b60532 (patch) | |
| tree | 25b197830899afa554179db0163b92472725f544 | |
| parent | 0cdeacf41b5473c64007cd3b0b26f763758222d3 (diff) | |
| download | ffmpeg-30c644afebb991b61dec313cc2d6a01971b60532.tar.gz | |
avformat/oggenc: Check segments_count for headers too
Fixes infinite loop and segfault in ogg_buffer_data()
Fixes Ticket4806
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 81a8701eb52d2b6469ae16ef442ce425388141b7)
| -rw-r--r-- | libavformat/oggenc.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c index 3d4519c1ac..1fb7dd54a2 100644 --- a/libavformat/oggenc.c +++ b/libavformat/oggenc.c @@ -256,7 +256,7 @@ static int ogg_buffer_data(AVFormatContext *s, AVStream *st, if (i == total_segments) page->granule = granule; - if (!header) { + { AVStream *st = s->streams[page->stream_index]; int64_t start = av_rescale_q(page->start_granule, st->time_base, @@ -264,10 +264,13 @@ static int ogg_buffer_data(AVFormatContext *s, AVStream *st, int64_t next = av_rescale_q(page->granule, st->time_base, AV_TIME_BASE_Q); - if (page->segments_count == 255 || - (ogg->pref_size > 0 && page->size >= ogg->pref_size) || - (ogg->pref_duration > 0 && next - start >= ogg->pref_duration)) { + if (page->segments_count == 255) { ogg_buffer_page(s, oggstream); + } else if (!header) { + if ((ogg->pref_size > 0 && page->size >= ogg->pref_size) || + (ogg->pref_duration > 0 && next - start >= ogg->pref_duration)) { + ogg_buffer_page(s, oggstream); + } } } } |