aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-09-18 16:42:21 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-09-26 16:51:03 +0200
commit765b73c9be6e37ab40a61a43b63bba2404030cbb (patch)
tree56692eaaa6bccb501928a1530b2288f2a2b94779
parent964fb9f59f1054052875389c73bec3278d9c2519 (diff)
downloadffmpeg-765b73c9be6e37ab40a61a43b63bba2404030cbb.tar.gz
avformat/sdsdec: Use av_rescale() to avoid intermediate overflow in duration calculation
Fixes: signed integer overflow: 72128794995445727 * 240 cannot be represented in type 'long' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_SDS_fuzzer-6628185583779840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit aa8eb1bed075931b0ce0a8bc9a8ff5882830044c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/sdsdec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/sdsdec.c b/libavformat/sdsdec.c
index c70f5af849..2289e1bdac 100644
--- a/libavformat/sdsdec.c
+++ b/libavformat/sdsdec.c
@@ -112,7 +112,7 @@ static int sds_read_header(AVFormatContext *ctx)
st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO;
st->codecpar->channels = 1;
st->codecpar->sample_rate = sample_period ? 1000000000 / sample_period : 16000;
- st->duration = (avio_size(pb) - 21) / (127) * s->size / 4;
+ st->duration = av_rescale((avio_size(pb) - 21) / 127, s->size, 4);
avpriv_set_pts_info(st, 64, 1, st->codecpar->sample_rate);