aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-03-20 22:54:31 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2022-04-06 20:38:06 +0200
commit023b7e79792020af978c1743d565ae4326395dc6 (patch)
treef372b47ac50ce7e44596581d65270892e69273d6
parenta1baef131a11bd582196139cdee8892d667481a8 (diff)
downloadffmpeg-023b7e79792020af978c1743d565ae4326395dc6.tar.gz
avformat/hls: Check target_duration
Fixes: signed integer overflow: 77777777777777 * 1000000 cannot be represented in type 'long long' Fixes: 45545/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-6438101247983616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Steven Liu <lingjiujianke@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit a8fd3f7fab83e1beea1c441e1a2e538e7aa431a5) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/hls.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/libavformat/hls.c b/libavformat/hls.c
index a831e3f10c..a48c081ece 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -813,10 +813,16 @@ static int parse_playlist(HLSContext *c, const char *url,
&info);
new_rendition(c, &info, url);
} else if (av_strstart(line, "#EXT-X-TARGETDURATION:", &ptr)) {
+ int64_t t;
ret = ensure_playlist(c, &pls, url);
if (ret < 0)
goto fail;
- pls->target_duration = strtoll(ptr, NULL, 10) * AV_TIME_BASE;
+ t = strtoll(ptr, NULL, 10);
+ if (t < 0 || t >= INT64_MAX / AV_TIME_BASE) {
+ ret = AVERROR_INVALIDDATA;
+ goto fail;
+ }
+ pls->target_duration = t * AV_TIME_BASE;
} else if (av_strstart(line, "#EXT-X-MEDIA-SEQUENCE:", &ptr)) {
ret = ensure_playlist(c, &pls, url);
if (ret < 0)