aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2019-04-20 00:03:14 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-05-11 19:04:05 +0200
commit9fad760f56483f0b5503457c780d9f80a84784c6 (patch)
tree2b80c00a829eafa4254ba8f09ceb285158c3258d
parente38fc0af12c7b8b65b05039e6209810bac9b8325 (diff)
downloadffmpeg-9fad760f56483f0b5503457c780d9f80a84784c6.tar.gz
lavf/webm_chunk: Respect buffer size
The last argument of av_strlcpy is supposed to contain the size of the destination buffer, but it was filled with the size of the source string, effectively negating its very purpose. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 73ef1f47f59333328264a968c8fbbcfb0bf0643f) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/webm_chunk.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c
index f8dbaa3339..3f91162da7 100644
--- a/libavformat/webm_chunk.c
+++ b/libavformat/webm_chunk.c
@@ -96,7 +96,7 @@ static int get_chunk_filename(AVFormatContext *s, int is_header, char *filename)
av_log(oc, AV_LOG_ERROR, "No header filename provided\n");
return AVERROR(EINVAL);
}
- av_strlcpy(filename, wc->header_filename, strlen(wc->header_filename) + 1);
+ av_strlcpy(filename, wc->header_filename, MAX_FILENAME_SIZE);
} else {
if (av_get_frame_filename(filename, MAX_FILENAME_SIZE,
s->filename, wc->chunk_index - 1) < 0) {