aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2012-09-09 14:11:03 +0200
committerMichael Niedermayer <michaelni@gmx.at>2012-09-09 14:11:03 +0200
commitd7cb5a8daf73825d4ffa623be4c2b798c81f41a5 (patch)
tree916ee53f88a456f9b077a3cf6db2872572a34802
parent1fc3e8f4ea49d01b2eab609ff94fa6c860da0043 (diff)
downloadffmpeg-d7cb5a8daf73825d4ffa623be4c2b798c81f41a5.tar.gz
ffmpeg_filter: fix unsafe snprintf() usage
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-rw-r--r--ffmpeg_filter.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c
index b7f20cc218..1887ffec4e 100644
--- a/ffmpeg_filter.c
+++ b/ffmpeg_filter.c
@@ -424,18 +424,17 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter,
if (sample_fmts || sample_rates || channel_layouts) {
AVFilterContext *format;
char args[256];
- int len = 0;
+ args[0] = 0;
if (sample_fmts)
- len += snprintf(args + len, sizeof(args) - len, "sample_fmts=%s:",
+ av_strlcatf(args, sizeof(args), "sample_fmts=%s:",
sample_fmts);
if (sample_rates)
- len += snprintf(args + len, sizeof(args) - len, "sample_rates=%s:",
+ av_strlcatf(args, sizeof(args), "sample_rates=%s:",
sample_rates);
if (channel_layouts)
- len += snprintf(args + len, sizeof(args) - len, "channel_layouts=%s:",
+ av_strlcatf(args, sizeof(args), "channel_layouts=%s:",
channel_layouts);
- args[len - 1] = 0;
av_freep(&sample_fmts);
av_freep(&sample_rates);