diff options
| author | Diego Biurrun <diego@biurrun.de> | 2012-10-25 18:33:38 +0200 |
|---|---|---|
| committer | Diego Biurrun <diego@biurrun.de> | 2012-11-11 20:43:28 +0100 |
| commit | 97bf7c03b1338a867da52c159a2afecbdedcfa88 (patch) | |
| tree | 6171b1e592c05a8d7e13f7d4da248ff61d7782ee | |
| parent | a903f8f087b0bdcc5643054147f3a5f278e7eb99 (diff) | |
| download | ffmpeg-97bf7c03b1338a867da52c159a2afecbdedcfa88.tar.gz | |
doc: git-howto: Leave reviewers time to react before pushing patches
| -rw-r--r-- | doc/git-howto.texi | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 68e0061d74..5a8e2a3823 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just the result of a series of patches. So if you have a series of commits to push, run the test suite on every single commit. +Give other developers a reasonable amount of time to look at and review +patches before you push them. Not everybody is online 24/7, but may wish +to look at and comment on a patch nonetheless. The time you leave depends +on the urgency and complexity of the patch. Use your common sense to pick +a timeframe that allows everybody that you think may wish to comment +and/or should comment on the change an opportunity to see it. + Finally, after pushing, mark all patches as committed on @url{http://patches.libav.org/,patchwork}. Sometimes this is not automatically done when a patch has been |