diff options
author | George Boyle <george@thebuds.net> | 2015-06-16 08:25:01 +0100 |
---|---|---|
committer | Carl Eugen Hoyos <cehoyos@ag.or.at> | 2015-06-19 10:10:43 +0200 |
commit | a9b600cf3995bc075090f4f1dbfbf772e21a4d5b (patch) | |
tree | f178202799b57428145b38245e76eb84b7e5b6d6 | |
parent | c3c8365dbd3b677207998e5120f7b78850e3532c (diff) | |
download | ffmpeg-a9b600cf3995bc075090f4f1dbfbf772e21a4d5b.tar.gz |
avcodec/flacenc: Fix Invalid Rice order
Fixes ticket #4628.
The problem arose, in the sample file at least, in the last block where the
minimum and maximum Rice partition orders were both 0. In that case, and any
other where pmax == pmin, the original UINT32_MAX placeholder value for
bits[opt_porder] was getting overwritten before the comparison to check if the
current partition order is a new optimal, so the correct partition order and
RiceContext params were not being set.
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 2469ed32c81ebf2347e6883091c566724b286167)
-rw-r--r-- | libavcodec/flacenc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index cdfeaf87cd..29bd9999b5 100644 --- a/libavcodec/flacenc.c +++ b/libavcodec/flacenc.c @@ -705,7 +705,7 @@ static uint64_t calc_rice_params(RiceContext *rc, bits[pmin] = UINT32_MAX; for (i = pmax; ; ) { bits[i] = calc_optimal_rice_params(&tmp_rc, i, sums, n, pred_order, kmax, exact); - if (bits[i] < bits[opt_porder]) { + if (bits[i] < bits[opt_porder] || pmax == pmin) { opt_porder = i; *rc = tmp_rc; } |